Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support config file watch and 2-phase reload #121

Merged
merged 2 commits into from
Nov 4, 2024
Merged

Conversation

ericwen229
Copy link
Contributor

What type of PR is this?

feat

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

支持动态监听本地配置文件和更新配置(二阶段提交)

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

@ericwen229 ericwen229 requested a review from ihciah October 22, 2024 08:31
@ericwen229 ericwen229 force-pushed the feat-config-reload branch 7 times, most recently from b9a2814 to cd7ac0c Compare October 22, 2024 10:31
Edited by @ihciah, original commit: cd7ac0c

Co-authored-by: ericwen229 <[email protected]>
@ihciah ihciah force-pushed the feat-config-reload branch from cd7ac0c to cd0e76f Compare November 4, 2024 08:42
@ihciah
Copy link
Contributor

ihciah commented Nov 4, 2024

I edited the commit and rebased it. The original branch is kept at branch feat-config-reload-ericwen229.

@ihciah
Copy link
Contributor

ihciah commented Nov 4, 2024

TODOs:

  1. Do we need to provide a simple one-time config load example for users?
  2. Support something like inotify in monoio and use it instead of polling read file and comparing.

@ihciah ihciah merged commit af97199 into main Nov 4, 2024
8 checks passed
@ihciah ihciah deleted the feat-config-reload branch November 14, 2024 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants