Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: generic protocol detector #122

Merged
merged 1 commit into from
Nov 5, 2024
Merged

feat: generic protocol detector #122

merged 1 commit into from
Nov 5, 2024

Conversation

ihciah
Copy link
Collaborator

@ihciah ihciah commented Oct 24, 2024 •
edited
Loading

Goal: Generic protocol detection

  • Detect trait definition
  • Common detect implementation(FixedLengthDetector, PrefixDetector)
    • Detector used by gRPC/thrift(renamed HttpVersionDetect to H2Detect)
      • Note: Message level detection is not related here. So here we only detect connection level protocol like h2.
  • Generic DetectService
  • Multi branch assembly util
    • Will be implemented in another PR in service-async crate.

@ihciah ihciah self-assigned this Oct 24, 2024
@ihciah ihciah requested a review from har23k November 4, 2024 07:03
@ihciah ihciah merged commit c547492 into main Nov 5, 2024
8 checks passed
@ihciah ihciah deleted the generic-detect branch November 14, 2024 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@har23k har23k har23k approved these changes

Assignees

@ihciah ihciah

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ihciah @har23k