Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typos in documentation and examples #83

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Fix typos in documentation and examples #83

merged 1 commit into from
Dec 19, 2023

Conversation

yadaiio
Copy link
Contributor

@yadaiio yadaiio commented Nov 6, 2023

This pull request fixes a few typos with the help of https://github.com/szepeviktor/typos-on-you.

@yadaiio
Copy link
Contributor Author

yadaiio commented Nov 6, 2023

Noticed that PHPUnit is failing with an exit code 1 during code coverage. In my opinion, I haven't made any changes to the actual code. Is there something broken on your side or did I do something wrong here?

@clue clue added the documentation Improvements or additions to documentation label Dec 17, 2023
@clue clue added this to the v1.5.0 milestone Dec 17, 2023
clue
clue reviewed Dec 17, 2023
View reviewed changes
Copy link
Owner

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yadaiio Thanks for looking into this! I've just filed #84 to fix the unrelated test error. Once this is merged, your changes need to rebased and should be ready to go otherwise. I'll make sure to send a ping your way, unless you beat me to it :shipit:

@yadaiio
Copy link
Contributor Author

yadaiio commented Dec 18, 2023

After the pull request #84 made by @clue was merged, I rebased this pull request. Thank you so much for putting your effort into this @clue and I'm happy everything's running green now.

clue
clue approved these changes Dec 19, 2023
View reviewed changes
Copy link
Owner

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yadaiio Thank you for the update, changes LGTM! :shipit:

@clue clue merged commit 9209885 into clue:1.x Dec 19, 2023
12 checks passed
@yadaiio yadaiio mentioned this pull request Dec 19, 2023
Merged
@yadaiio yadaiio mentioned this pull request Mar 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimonFrings SimonFrings SimonFrings approved these changes

@clue clue clue approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
v1.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@yadaiio @clue @SimonFrings