Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a typo in QueueAllTest #44

Merged
merged 2 commits into from
Jul 29, 2023
Merged

Fix a typo in QueueAllTest #44

merged 2 commits into from
Jul 29, 2023

Conversation

szepeviktor
Copy link
Contributor

@szepeviktor szepeviktor commented Jul 28, 2023

Just fixing that typo.

There are a few "occured" typos.
https://github.com/search?q=repo%3Aclue%2Freactphp-mq%20occured&type=code

@clue clue added this to the v1.7.0 milestone Jul 29, 2023
Copy link
Owner

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@szepeviktor Thank you for spotting and filing this PR! If you've already identified more minor typos, perhaps you can amend your changes to include these fixes as well? Thank you!

@szepeviktor
Copy link
Contributor Author

szepeviktor commented Jul 29, 2023

You're welcome.

more minor typos

This is the measurement result.
https://github.com/szepeviktor/typos-on-you/actions/runs/5693481260/job/15432666915
People like "invokable", so I've left that alone.

@clue
Copy link
Owner

clue commented Jul 29, 2023

This is the measurement result.
https://github.com/szepeviktor/typos-on-you/actions/runs/5693481260/job/15432666915

Very interesting rules and I really like the idea/concept, thank you for sharing!

People like "invokable", so I've left that alone.

Interesting one as I couldn't find a definitive source, but it looks like both variants should indeed be fine (see https://en.wiktionary.org/wiki/invocable) and thus should not be reported, but we're probably out of scope of this ticket at this point :-)

In either case, thank you for the fixes again, keep it up! 👍

@clue clue merged commit 0bac6e1 into clue:1.x Jul 29, 2023
12 checks passed
@szepeviktor szepeviktor deleted the patch-1 branch July 29, 2023 12:52
@szepeviktor
Copy link
Contributor Author

Very interesting rules and I really like the idea/concept, thank you for sharing!

You find dozens of goodies in this repo: https://github.com/szepeviktor/byte-level-care/tree/master/.github/workflows

@yadaiio yadaiio mentioned this pull request Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants