Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run tests on PHP 8.3 and update test suite #46

Merged
merged 1 commit into from
Dec 31, 2023
Merged

Run tests on PHP 8.3 and update test suite #46

merged 1 commit into from
Dec 31, 2023

Conversation

yadaiio
Copy link
Contributor

@yadaiio yadaiio commented Dec 28, 2023

This pull request builds on top of #43 #41 #39, #37 and #32.

References: reactphp/socket#300, clue/reactphp-zenity#63, clue/reactphp-csv#33, reactphp/promise-stream#39 and others.

@clue clue added this to the v1.7.0 milestone Dec 28, 2023
clue
clue reviewed Dec 28, 2023
View reviewed changes
Copy link
Owner

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yadaiio Thank you for looking into this, may I ask you to squash this into a single commit? 👍

clue
clue approved these changes Dec 31, 2023
View reviewed changes
Copy link
Owner

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yadaiio Thanks for the update, changes LGTM! :shipit:

@clue clue merged commit b27e662 into clue:1.x Dec 31, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clue clue clue approved these changes

Assignees
No one assigned
Labels
new feature
Projects
None yet
Milestone
v1.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@yadaiio @clue