Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve documentation and examples #47

Merged
merged 1 commit into from
Mar 29, 2024
Merged

Improve documentation and examples #47

merged 1 commit into from
Mar 29, 2024

Conversation

yadaiio
Copy link
Contributor

@yadaiio yadaiio commented Feb 20, 2024

@yadaiio yadaiio force-pushed the Improve_documentation_and_examples branch from f5e9505 to 0e6030c Compare February 21, 2024 07:30
SimonFrings
SimonFrings suggested changes Feb 21, 2024
View reviewed changes
Copy link
Contributor

@SimonFrings SimonFrings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some remarks below

README.md Outdated Show resolved Hide resolved
examples/03-http-any.php Outdated Show resolved Hide resolved
@yadaiio yadaiio force-pushed the Improve_documentation_and_examples branch from 0e6030c to 0426973 Compare February 22, 2024 07:06
@yadaiio
Copy link
Contributor Author

yadaiio commented Feb 22, 2024

Thanks for noticing this, should be changed right now @SimonFrings. ✨

@yadaiio yadaiio force-pushed the Improve_documentation_and_examples branch from 0426973 to 52b3bad Compare February 22, 2024 10:45
SimonFrings
SimonFrings approved these changes Feb 22, 2024
View reviewed changes
Copy link
Contributor

@SimonFrings SimonFrings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@SimonFrings SimonFrings added the documentation Improvements or additions to documentation label Feb 22, 2024
clue
clue reviewed Mar 8, 2024
View reviewed changes
examples/03-http-any.php Outdated Show resolved Hide resolved
@yadaiio yadaiio force-pushed the Improve_documentation_and_examples branch from 52b3bad to 7872737 Compare March 12, 2024 14:10
@yadaiio yadaiio force-pushed the Improve_documentation_and_examples branch from 7872737 to ea8be08 Compare March 14, 2024 07:34
SimonFrings
SimonFrings approved these changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@SimonFrings SimonFrings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

clue
clue reviewed Mar 14, 2024
View reviewed changes
examples/01-http.php Outdated Show resolved Hide resolved
examples/02-http-all.php Outdated Show resolved Hide resolved
examples/03-http-any.php Outdated Show resolved Hide resolved
@yadaiio yadaiio force-pushed the Improve_documentation_and_examples branch from ea8be08 to 4d7c1b3 Compare March 14, 2024 10:50
@clue clue mentioned this pull request Mar 16, 2024
Merged
@SimonFrings SimonFrings requested a review from clue March 21, 2024 13:32
@clue clue added this to the v1.7.0 milestone Mar 24, 2024
clue
clue approved these changes Mar 24, 2024
View reviewed changes
Copy link
Owner

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yadaiio Thanks for looking into this, changes LGTM! :shipit:

@clue clue merged commit fd2235d into clue:1.x Mar 29, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimonFrings SimonFrings SimonFrings approved these changes

@clue clue clue approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
v1.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@yadaiio @clue @SimonFrings