Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update close handler to avoid unhandled promise rejections #117

Merged
merged 1 commit into from
May 28, 2024

Conversation

clue
Copy link
Owner

@clue clue commented May 28, 2024

Builds on top of reactphp/promise#248, #113 and #106
Resolves / closes #115

@clue clue added this to the v1.5.0 milestone May 28, 2024
@clue clue requested a review from cassifyit May 28, 2024 10:23
Copy link
Collaborator

@cassifyit cassifyit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@cassifyit cassifyit merged commit d0009ca into clue:1.x May 28, 2024
14 checks passed
@clue clue deleted the unhandled-rejections branch May 28, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for ReactPHP Promise v3, avoid unhandled promise rejections
2 participants