Dbcsql #442
Dbcsql #442
Conversation
Added dbc format Added new SqlStorage instance for each DBC Added loading part.
Make it easier and less prone to errors.
Will make it easier to replace dbcstore by sqlstore.
Make it more compatible wiht c++ iterator standard. silent a casting warning.
- sCreatureDataAddonStorage - sCreatureInfoAddonStorage - sCreatureModelStorage - sEquipmentStorage - sEquipmentStorageRaw - sPageTextStore - sItemStorage - sInstanceTemplate - sWorldTemplate - sConditionStorage - sSpellTemplate - sFactionStore - sCreatureConditionalSpawnStore
Now we are able to define the index in the format and it can not be the first column. This is needed for AreaTable. However we might need to double check why its done that way for that table. Rremoved the need to define the name of the column as an index because code can find it using the provided format. Added the support for table that have no index like gtcombatratings.
using n/d to define the index and removing column name.
|
the idea is very interesting and supported by our team. |
If you have a team, feel free to also open pull requests and not only issues. More man power would be appreciated. |
|
@cyberium is there anything else that must be implemented before this? or u are planing in the near future to implement it? |
killerwife
force-pushed
the
master
branch
2 times, most recently
from
d794e29
to
b85aea8
Compare
|
Not sure yet what to do with that |
|
well, I supose that your intention was to make things easier for scripting and modifying data for unreacheable cases. Reading through the dbc structure file, in my little j=knowledge, I was some stuff that were not yet implemented, or unk the purpose of those collumns. Also loading them from db is way faster, it would give a slight boost to the server (my opinion) So what do u say @cyberium ? P.S. Just an opinion, nothing mandatory, cause I am no developer and my knowledge is resumed to testing and reading on google |
🍰 Pullrequest
Remove support for dbc files and support downloading them from db instead.
Proof
Issues
Allowing to have them in db will open a new world of possibilities to fix some specific case that was not or at least more difficult to do before.
Translations already included.
How2Test
Todo / Checklist
Yes this will be ported to other core when this PR will be merged.