-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add system and utils unit tests #34
Conversation
@marjanAlbouye While we're making some small changes to the reference units attributes and setters, what do you think about adding a check for the correct dimensions? Unyt units have a For example, we should throw an error if someone tries setting |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #34 +/- ##
==========================================
+ Coverage 89.17% 91.38% +2.20%
==========================================
Files 18 18
Lines 1303 1312 +9
==========================================
+ Hits 1162 1199 +37
+ Misses 141 113 -28
|
@chrisjonesBSU |
ToDo for me: Move all the checks related to units and their dimensions to utils to avoid having duplicated code. Also, allow unit strings with |
Do you want to do that in this PR, or merge this and make a separate PR that streamlines the reference unit setters? |
I was planning to do it in this PR but this PR is getting big. I'll merge this one and start a new one. |
This PR adds more tests for the following modules:
1- All the setter methods for reference values in
System
base class. Cases withReferenceUnitError
are being tested too.2-
ScaleEpsilon
andScaleSigma
in utils actions.3-
xml_to_gmso_ff
in ff_utils.