-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move reference values unit validation to utils #36
Conversation
for more information, see https://pre-commit.ci
Thanks for doing this! It looks like there might be a typo in one of the unit tests:
Looks like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once that last unit test passes :) Thanks!
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #36 +/- ##
==========================================
+ Coverage 92.04% 92.23% +0.18%
==========================================
Files 18 18
Lines 1320 1326 +6
==========================================
+ Hits 1215 1223 +8
+ Misses 105 103 -2
|
This PR moves a bunch of duplicated codes that validates reference units to the utils module.
Unit tests have been added for all new functionalities.