Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Readthedocs into Main #52

Closed
wants to merge 39 commits into from
Closed

Merge Readthedocs into Main #52

wants to merge 39 commits into from

Conversation

RainierBarrett
Copy link
Contributor

So we can check doc builds as we continue on other branches

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #52 (8688e67) into main (98e2193) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #52   +/-   ##
=======================================
  Coverage   93.88%   93.88%           
=======================================
  Files          18       18           
  Lines        1357     1357           
=======================================
  Hits         1274     1274           
  Misses         83       83           
Files Changed Coverage Δ
hoomd_organics/base/molecule.py 96.62% <ø> (ø)
hoomd_organics/base/system.py 89.76% <ø> (ø)
hoomd_organics/modules/welding.py 94.25% <ø> (ø)
hoomd_organics/utils/utils.py 100.00% <ø> (ø)

@chrisjonesBSU
Copy link
Member

I think we probably don't need the utils directory part of the documentation right now. Most of that is used internally, and at some point we should probably move the actions.py stuff into its own module.

Other than that, I think we can merge this.

Copy link
Collaborator

@marjanalbooyeh marjanalbooyeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RainierBarrett
We can merge this to main if things are ready. I will update my docstrings branch once this is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants