TP Disk/Overlap seed expansion #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jasonfan393 this fails the gitlab CI on the HLS build for the c simulation. is this expected? |
not expected, looks like one of my 'cleanups' to get past the quality check has broken the co-sim somehow, looking at it now |
aryd
requested changes
Aug 1, 2023
jasonfan393
force-pushed
the
TPDisksAndOverlaps
branch
from
9597d59
to
1c1aab2
Compare
Conflicts: emData/download.sh
aryd
force-pushed
the
TPDisksAndOverlaps
branch
from
1c1aab2
to
d4eab01
Compare
… adding a few clarifying comments
aryd
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR adds Disk/overlap (L1D1 L2D1 D1D2 D3D4) seeds to TP. Tested as matching emulation on all TPs. Adds two new "TrackletCalculator_calculate*" modules for disks and overlaps each, auto-written by SW with minor tweaks, which are the majority of the 4000 lines of this PR.
Timing fails by HLS csynth estimate but passes on full implementation.
Adds an additional bit into AllStubInnerMemory in disks for negative disk information, written by VMRCM.