-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new TkAlMap version (xy inversion fix) #2
Conversation
A new Pull Request was created by @SenneVanPutte for branch master. @smuzaffar, @yuanchao, @malbouis, @iarspider, @cmsbuild, @tvami, @ddaina, @francescobrivio can you please review it and eventually sign? Thanks. |
@cmsbuild , please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8e38af/20864/summary.html Comparison SummarySummary:
|
+alca |
+externals |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8e38af/22605/summary.html The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Comparison SummarySummary:
|
@SenneVanPutte , in order not to sign it blindly, could you please add to the PR description two lines of explanation, or a link to a presentation (at an AlCa meeting?), or anything else that can explain what you are doing and why? |
I think it's usueful to have it, but not a showstopper not to have it, i.e. I think we can merge it in 12_3_X |
Thank you @tvami |
It's needed to make TrackerMap plots formatted as in the alignment paper TRK-20-001 e.g. |
+1 |
xy coordinates where flipped to be equivalent everywhere