Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix of the L1MenuWriter needed for the X2O procedure and update of the L1UpgradeTfMuonShowerTreeProducer #987

Conversation

elfontan
Copy link

@elfontan elfontan commented Feb 23, 2022

PR description:

This PR includes the update of two files:

  • the L1MenuWriter that it is called when running the dumpMenu.py script to manually upload a new tag to condDB via X2O procedure. It was crashing because of an exception MustUseESGetToken;
  • the L1UpgradeTfMuonShowerTreeProducer that was previously updated for the deprecated usage of EDAnalyzer in central cmssw as a part of PR#36018. That PR#36018 was actually missing the corresponding updates to the destructor and to the usage of the SharedResources.

These two changes are also part of another PR to central CMSSW, PR#37042, that it is supposed to complete PR#36018 and includes the update of the first file. This means that no backport of this PR is needed to the Offline SW branch.

PR validation:

Basic tests performed successfully starting from CMSSW_12_3_0_pre1 with the following setup:
From CMSSW_12_3_0_pre1/src:

cmsrel CMSSW_12_3_0_pre1
cd CMSSW_12_3_0_pre1/src
cmsenv
git cms-init
git remote add cms-l1t-offline [email protected]:cms-l1t-offline/cmssw.git
git fetch cms-l1t-offline l1t-integration-CMSSW_12_3_0
git cms-merge-topic -u cms-l1t-offline:l1t-integration-v119.0
git cms-checkdeps -A -a
scram b -j 8
scram b runtests
scram build code-checks
scram build code-format

@elfontan
Copy link
Author

Actually the scram b runtests was mostly ok but it had some problems:

  • test runtestPhysicsToolsPatAlgos had ERRORS => It looks related to a file that was not opened correctly just before:

XrdCl::File::Open(name='root://xrootd-cms.infn.it//store/relval/CMSSW_9_2_2/RelValProdTTbar_13/AODSIM/91X_mcRun2_asymptotic_v3-v1/10000/EEB99F74-DA4D-E711-A41C-0025905A48F2.root', flags=0x10,
permissions=0660) => error '[ERROR] Server responded with an error: [3011] No servers are available to read the file.

  • test trackerMaterialAnalysisPlots had ERRORS => Core dumped:

/afs/cern.ch/work/e/elfontan/private/L1TMenu/OSW_PR/CMSSW_12_3_0_pre1/src/SimTracker/TrackerMaterialAnalysis/test/genTrackerPlots.sh: line 10: 1758 Aborted (core dumped) cmsRun ${VGEO_D
IR}/test/trackingMaterialAnalyser_ForPhaseII.py > $TEST_DIR/plotter.log 2>&1
---> test trackerMaterialAnalysisPlots had ERRORS
TestTime:286
^^^^ End Test trackerMaterialAnalysisPlots ^^^^

I do not see how they might be related to our changes...
I do not even know if it is a standard procedure to run scram b runtests in the Offline SW as it is asked in central cmssw.

@elfontan
Copy link
Author

Anyway, I see that the corresponding PR to central cmssw encountered some issues @cecilecaillol @epalencia.
To be verified which kind of update is needed and it has to be included also here before considering to merge.

@elfontan
Copy link
Author

elfontan commented Feb 24, 2022

Now the PR#37042 to central cmssw is fully signed, so I think that we are same also on this side.
It needed to be tested with PR#37038 too.

(Still, I am not sure if the two errors mentioned above when running the scram b runtests have to be considered as relevant or not.)

@elfontan elfontan closed this Mar 2, 2022
@elfontan elfontan deleted the EFtoOSW_fixForX2O branch March 2, 2022 17:57
@elfontan elfontan restored the EFtoOSW_fixForX2O branch March 2, 2022 17:58
@elfontan elfontan reopened this Mar 9, 2022
@elfontan elfontan closed this Mar 24, 2022
@elfontan
Copy link
Author

elfontan commented Mar 24, 2022

After the rebase to pre6, the relevant changes to:

are already present, so I am closing the current PR.

@elfontan elfontan deleted the EFtoOSW_fixForX2O branch January 19, 2023 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant