Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UL case for JMS&JMR SD corr in fatJetUncertainties #286

Merged
merged 2 commits into from
Nov 21, 2022

Conversation

bartokm
Copy link
Contributor

@bartokm bartokm commented Jul 19, 2021

When using fatJetUncertaintiesProducer with UL era (e.g. UL2018) the code crashes in this line, since era string doesn't cover UL cases in the previous if statement. With this simple fix the code works. Please note, that the corrections in JetWtagging twiki doesn't have separate factors for UL.

This issue was reported here: #285

@lathomas, @kirschen, @gouskos, @nowaythatsok

@alefisico
Copy link

alefisico commented Jul 19, 2021

Just to comment about the last statement "that the corrections in JetWtagging twiki doesn't have separate factors for UL".
We dont have yet values for UL campaigns. We were waiting for the nanoAOD version with the latest PUPPI tune. We plan to release these numbers asap.
In that sense, maybe you can create new categories for UL and temporarily copy the EOY values into the UL.

@bartokm
Copy link
Contributor Author

bartokm commented Jul 27, 2021

Thanks for your comment, I've created separate categories for UL in the latest commit.

@tomalin
Copy link

tomalin commented Oct 14, 2022

This PR is still needed, as the code crashes without it. But there has been no progress merging it in over a year. Is anyone reviewing NanoAOD PRs?

@clelange
Copy link
Contributor

@swertz and @vlimant are the new XPOG conveners who are historically responsible for this repository. I think the previous ones decided to deprecate nanoAOD-tools though and if so, this repository could be archived... The new Common Analysis Tools group might provide a new forum for this, but only in a few months and responsibilities will have to be discussed with XPOG.

@mariadalfonso
Copy link
Contributor

mariadalfonso commented Oct 20, 2022

@clelange and @lenzip you are admin of this cms-nanoAOD/nanoAOD-tools repository so that CAT and XPOG can decide how to go forward with this tools and other RDF and coffeea

@lenzip
Copy link
Contributor

lenzip commented Nov 21, 2022

I have reviewed this PR, it only adds new flags to enable computing of SF for fatjets in UL campaigns. Defaults are unaffected.

@lenzip lenzip merged commit ded19d8 into cms-nanoAOD:master Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

6 participants