Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR profiling: Run IB profiling on same VM #2366

Merged
merged 4 commits into from
Nov 12, 2024
Merged

PR profiling: Run IB profiling on same VM #2366

merged 4 commits into from
Nov 12, 2024

Conversation

gartung
Copy link
Member

@gartung gartung commented Nov 4, 2024

No description provided.

@gartung
Copy link
Member Author

gartung commented Nov 4, 2024

enable profiling

@gartung
Copy link
Member Author

gartung commented Nov 4, 2024

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2024

A new Pull Request was created by @gartung for branch master.

@aandvalenzuela, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2024 •
edited
Loading

cms-bot internal usage

@gartung gartung mentioned this pull request Nov 4, 2024
Closed
@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-018b9a/42588/summary.html
COMMIT: 8f7c787
CMSSW: CMSSW_14_2_X_2024-11-04-1100/el8_amd64_gcc12
Additional Tests: PROFILING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cms-bot/2366/42588/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 72 lines to the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3569567
  • DQMHistoTests: Total failures: 415
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3569132
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
  • Checked 201 log files, 171 edm output root files, 46 DQM output files
  • TriggerResults: no differences found

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2024

Pull request #2366 was updated.

@gartung
Copy link
Member Author

gartung commented Nov 4, 2024

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 5, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-018b9a/42589/summary.html
COMMIT: 0c36670
CMSSW: CMSSW_14_2_X_2024-11-04-1100/el8_amd64_gcc12
Additional Tests: PROFILING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cms-bot/2366/42589/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 73 lines to the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3569567
  • DQMHistoTests: Total failures: 458
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3569089
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
  • Checked 201 log files, 171 edm output root files, 46 DQM output files
  • TriggerResults: no differences found

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 5, 2024

Pull request #2366 was updated.

@gartung
Copy link
Member Author

gartung commented Nov 5, 2024

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-018b9a/42636/summary.html
COMMIT: 7685059
CMSSW: CMSSW_14_2_X_2024-11-06-1100/el8_amd64_gcc12
Additional Tests: PROFILING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cms-bot/2366/42636/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3343138
  • DQMHistoTests: Total failures: 376
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3342742
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
  • Checked 195 log files, 172 edm output root files, 46 DQM output files
  • TriggerResults: no differences found

@makortel makortel mentioned this pull request Nov 8, 2024
Closed
@gartung
Copy link
Member Author

gartung commented Nov 11, 2024

@smuzaffar this change to the run-pr-profiling script is complete. The change to the formatting if the report will be submitted in another pull request.

@gartung
Squashed commit of the following:
14ee529 
commit 4b5ce3e
Author: Patrick Gartung <[email protected]>
Date:   Wed Nov 6 22:52:53 2024 +0100

    Use cd since pushd/popd does not work they way expected

commit 2361e05
Author: Patrick Gartung <[email protected]>
Date:   Wed Nov 6 21:30:16 2024 +0100

    export RUNALLSTEPS

commit fafb1d7
Author: Patrick Gartung <[email protected]>
Date:   Wed Nov 6 19:43:54 2024 +0100

    Leave environment set to get CMSSW_VERSION

commit 7df6c16
Author: Patrick Gartung <[email protected]>
Date:   Wed Nov 6 19:20:54 2024 +0100

    Use correct project command

commit a47d72b
Author: Patrick Gartung <[email protected]>
Date:   Wed Nov 6 18:46:40 2024 +0100

    Use full project command

commit 18d00f5
Author: Patrick Gartung <[email protected]>
Date:   Wed Nov 6 18:23:29 2024 +0100

    Set the IB environment before running the profiling for IB

commit 325b8e2
Author: Patrick Gartung <[email protected]>
Date:   Wed Nov 6 17:56:53 2024 +0100

    Make sure scram environment for IB+PR is not set when running IB profiling

commit 198bd08
Author: Patrick Gartung <[email protected]>
Date:   Wed Nov 6 17:44:23 2024 +0100

    close doe done loop

commit e7c90b7
Author: Patrick Gartung <[email protected]>
Date:   Wed Nov 6 17:18:26 2024 +0100

    Black formatting

commit 83f7db4
Author: Patrick Gartung <[email protected]>
Date:   Wed Nov 6 17:12:55 2024 +0100

    Run the profiling on the IB before running on the IB+PR

commit 8261056
Merge: e2d70cd 04a7d99
Author: Patrick Gartung <[email protected]>
Date:   Wed Nov 6 17:05:41 2024 +0100

    Merge remote-tracking branch 'upstream/master'

commit e2d70cd
Author: Patrick Gartung <[email protected]>
Date:   Wed Nov 6 02:01:11 2024 +0100

    Rename input->prdata output->ibdata. Accumulate metrics by module type.

commit 35565ba
Author: Patrick Gartung <[email protected]>
Date:   Tue Nov 5 22:24:26 2024 +0100

    Black formatting

commit 3b8921b
Merge: bb81d17 0cbd3d0
Author: Patrick Gartung <[email protected]>
Date:   Tue Nov 5 22:23:12 2024 +0100

    Merge remote-tracking branch 'upstream/master'

commit bb81d17
Author: Patrick Gartung <[email protected]>
Date:   Tue Nov 5 22:21:21 2024 +0100

    Black formatting

commit 28e277c
Author: Patrick Gartung <[email protected]>
Date:   Tue Nov 5 22:17:55 2024 +0100

    Use fraction of total time for comparison. Some total time at top of table

commit b077290
Author: Patrick Gartung <[email protected]>
Date:   Tue Nov 5 18:53:34 2024 +0100

    Try with scaled diffs

commit e6b9d86
Author: Patrick Gartung <[email protected]>
Date:   Tue Nov 5 20:16:37 2024 +0100

    Put IB fast timer json in a directory where it will be copied back

commit 0c36670
Author: Patrick Gartung <[email protected]>
Date:   Mon Nov 4 23:56:34 2024 +0100

    Copy step2.root to correct directory

commit 8f7c787
Author: Patrick Gartung <[email protected]>
Date:   Mon Nov 4 19:57:59 2024 +0100

    Copy step2.root from IB profiling
@gartung
Get the environment setting correct
6f73215
@gartung
Use variable scram won't unset
6be906f
@cmsbuild
Copy link
Contributor

Pull request #2366 was updated.

@gartung
Copy link
Member Author

gartung commented Nov 11, 2024

please test

@cmsbuild
Copy link
Contributor

Pull request #2366 was updated.

@gartung
Copy link
Member Author

gartung commented Nov 11, 2024

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-018b9a/42739/summary.html
COMMIT: 9186612
CMSSW: CMSSW_14_2_X_2024-11-11-1100/el8_amd64_gcc12
Additional Tests: PROFILING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cms-bot/2366/42739/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@makortel
Copy link
Contributor

@smuzaffar This PR should be ready to be merged now (unless you have further comments)

@smuzaffar smuzaffar merged commit 5684a3a into cms-sw:master Nov 12, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smuzaffar smuzaffar smuzaffar left review comments

Assignees
No one assigned
Labels
externals-pending orp-pending pending-signatures tests-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gartung @cmsbuild @makortel @smuzaffar