Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ROOT modules branch #7320

Merged
merged 1 commit into from
Sep 21, 2021
Merged

Conversation

mrodozov
Copy link
Contributor

No description provided.

@mrodozov
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mrodozov (Mircho Rodozov) for branch IB/CMSSW_12_1_X/rootmodule.

@smuzaffar, @iarspider, @mrodozov can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-59d066/18764/summary.html
COMMIT: 7ecd87f
CMSSW: CMSSW_12_1_CXXMODULE_X_2021-09-17-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7320/18764/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-59d066/18764/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-59d066/18764/git-merge-result

Build

I found compilation error when building:

>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_CXXMODULE_X_2021-09-17-2300/src/FWCore/Reflection/src/TypeWithDict.cc
>> Building CXX Module LCG reflex dict from header file tmp/slc7_amd64_gcc900/src/FWCore/Reflection/src/FWCoreReflection/a/FWCoreReflection_xr.h
In file included from input_line_8:54:
In file included from ./tmp/slc7_amd64_gcc900/src/FWCore/Reflection/src/FWCoreReflection/a/FWCoreReflection_xr.h:1:
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_CXXMODULE_X_2021-09-17-2300/src/FWCore/Reflection/interface/BaseWithDict.h:33:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_CXXMODULE_X_2021-09-17-2300/src/FWCore/Reflection/interface/TypeWithDict.h:13:2: fatal error: module file '/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/slc7_amd64_gcc900/lcg/root/6.25.01-a3a652eec4c6ba64a0138299258180ba/lib/std.pcm' is out of date and needs to be rebuilt: signature mismatch
#include "FWCore/Utilities/interface/value_ptr.h"
 ^
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_CXXMODULE_X_2021-09-17-2300/src/FWCore/Reflection/interface/TypeWithDict.h:13:2: note: imported by module 'FWCoreUtilities' in '/cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc900/cms/cmssw/CMSSW_12_1_CXXMODULE_X_2021-09-17-2300/lib/slc7_amd64_gcc900/FWCoreUtilities.pcm'
rootcling: /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc900/lcg/root/6.25.01-a3a652eec4c6ba64a0138299258180ba/root-6.25.01/interpreter/llvm/src/tools/clang/lib/Lex/Lexer.cpp:3940: bool clang::Lexer::LexTokenInternal(clang::Token&, bool): Assertion `Result.is(tok::eof) && "Preprocessor did not set tok:eof"' failed.
 #0 0x00002b80af249f4e llvm::sys::PrintStackTrace(llvm::raw_ostream&) /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/slc7_amd64_gcc900/lcg/root/6.25.01-a3a652eec4c6ba64a0138299258180ba/root-6.25.01/interpreter/llvm/src/lib/Support/Unix/Signals.inc:533:22


@smuzaffar
Copy link
Contributor

+externals
modules IBs still does not work in patch mode

@smuzaffar smuzaffar merged commit a482e35 into IB/CMSSW_12_1_X/rootmodule Sep 21, 2021
@smuzaffar smuzaffar deleted the mrodozov-patch-4 branch September 21, 2021 07:40
@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_12_1_X/rootmodule IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants