Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BuildRules] Enable alpaka ROCm backend [13.0.x] #8347

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Mar 2, 2023

Backport of #8346.

@fwyzard
Copy link
Contributor Author

fwyzard commented Mar 2, 2023

backport #8346

@fwyzard
Copy link
Contributor Author

fwyzard commented Mar 2, 2023

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2023

A new Pull Request was created by @fwyzard (Andrea Bocci) for branch IB/CMSSW_13_0_X/master.

@smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@fwyzard
Copy link
Contributor Author

fwyzard commented Mar 2, 2023

please test for el8_ppc64le_gcc11

@fwyzard
Copy link
Contributor Author

fwyzard commented Mar 2, 2023

urgent

needed for 13.0.0

@cmsbuild cmsbuild added the urgent label Mar 2, 2023
@fwyzard
Copy link
Contributor Author

fwyzard commented Mar 2, 2023

please abort

@fwyzard
Copy link
Contributor Author

fwyzard commented Mar 2, 2023

please test with cms-sw/cmssw#40725

@fwyzard
Copy link
Contributor Author

fwyzard commented Mar 2, 2023

please test with cms-sw/cmssw#40725 for el8_ppc64le_gcc11

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-488b35/30994/summary.html
COMMIT: cea7f5f
CMSSW: CMSSW_13_0_X_2023-03-02-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8347/30994/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-488b35/30994/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-488b35/30994/git-merge-result

Comparison Summary

Summary:

  • You potentially removed 22 lines from the logs
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3557934
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3557912
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2023

Pull request #8347 was updated.

@fwyzard
Copy link
Contributor Author

fwyzard commented Mar 3, 2023

test parameters:

  • addpkg = DataFormats/Portable,DataFormats/PortableTestObjects,HeterogeneousCore/AlpakaCore,HeterogeneousCore/AlpakaInterface,HeterogeneousCore/AlpakaServices,HeterogeneousCore/AlpakaTest

@fwyzard
Copy link
Contributor Author

fwyzard commented Mar 3, 2023

please test

@fwyzard
Copy link
Contributor Author

fwyzard commented Mar 3, 2023

please test for el8_ppc64le_gcc11

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2023

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-488b35/31018/summary.html
COMMIT: 9b2fdf6
CMSSW: CMSSW_13_0_X_2023-02-28-1500/el8_ppc64le_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8347/31018/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-488b35/31018/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-488b35/31018/git-merge-result

Unit Tests

I found errors in the following unit tests:

---> test testONNXRuntime had ERRORS
---> test testFWCoreUtilities had ERRORS

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-488b35/31017/summary.html
COMMIT: 9b2fdf6
CMSSW: CMSSW_13_0_X_2023-03-02-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8347/31017/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-488b35/31017/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-488b35/31017/git-merge-result

Comparison Summary

Summary:

  • You potentially removed 33 lines from the logs
  • Reco comparison results: 10 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3557934
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3557906
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor

+externals
this can go in 13.0.X now

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2023

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_13_0_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Mar 3, 2023

+1

@perrotta
Copy link
Contributor

perrotta commented Mar 3, 2023

merge

@cmsbuild cmsbuild merged commit 770e0f9 into cms-sw:IB/CMSSW_13_0_X/master Mar 3, 2023
@fwyzard fwyzard deleted the IB/CMSSW_13_0_X/master_enable_ROCm_backend branch March 4, 2023 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants