Fix crash in ECAL local reco on GPU if ECAL is not in the run - 113X

[thomreis]

PR description:

This should fix crashes of the ECAL local reconstruction on GPU if the ECAL is not in the run as described in #34197
The changes to EcalRecHitProducerGPU.cc were not needed to fix the crash since currently the RecHits are produced on CPU only by default. However, the protection against empty inputs was added nevertheless to avoid the same issue in the future.

PR validation:

Processing of run 342110, for which ECAL was not in the run, does not crash anymore with these changes.

if this PR is a backport please specify the original PR and why you need to backport that PR:

Backport of #34292

[cmsbuild]

A new Pull Request was created by @thomreis (Thomas Reis) for CMSSW_11_3_X.

It involves the following packages:

EventFilter/EcalRawToDigi
RecoLocalCalo/EcalRecProducers

@perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@rchatter, @argiro, @Martin-Grunewald, @apsallid, @thomreis, @simonepigazzini this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

• Backported from Fix crash in ECAL local reco on GPU if ECAL is not in the run #34292

[thomreis]

type bugfix

[thomreis]

backport of #34292

[fwyzard]

enable gpu

[fwyzard]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9c1433/16356/summary.html
COMMIT: dac1a78
CMSSW: CMSSW_11_3_X_2021-06-30-1100/slc7_amd64_gcc900
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34293/16356/install.sh to create a dev area with all the needed externals and cmssw changes.

GPU Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 4
• DQMHistoTests: Total histograms compared: 9559
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 9558
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 3 files compared)
• Checked 12 log files, 9 edm output root files, 4 DQM output files
• TriggerResults: no differences found

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 3 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2877861
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2877832
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 37 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: no differences found

[slava77]

+reconstruction

for #34293 dac1a78

• code changes are in line with the PR description; the changes in the code are the same as in the master version Fix crash in ECAL local reco on GPU if ECAL is not in the run #34292
• jenkins tests pass and comparisons with the baseline show no (relevant) differences
  • notably, the pixel tracking test GPU workflow does not show any differences (while the master version had differences); I'm curious if this non-repeatability was introduced recently. @VinInn please clarify.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

master IB test looks ok.

[qliphy]

+1