HBHEGPU: protection when detector is out

[mariadalfonso]

fix issue reported in #34197

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34429/23838

• This PR adds an extra 20KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34429/23838/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34429/23838/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34429/23839

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @mariadalfonso for master.

It involves the following packages:

• RecoLocalCalo/HcalRecProducers (reconstruction)

@perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@apsallid, @abdoulline, @bsunanda this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy, @perrotta you are the release manager for this.

cms-bot commands are listed here

[mariadalfonso]

type bugfix

[perrotta]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-49cdd2/16692/summary.html
COMMIT: ccc744f
CMSSW: CMSSW_12_0_X_2021-07-11-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34429/16692/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2787742
• DQMHistoTests: Total failures: 868
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2786874
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: no differences found

[mariadalfonso]

enable gpu

[mariadalfonso]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-49cdd2/16707/summary.html
COMMIT: ccc744f
CMSSW: CMSSW_12_0_X_2021-07-12-1100/slc7_amd64_gcc900
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34429/16707/install.sh to create a dev area with all the needed externals and cmssw changes.

GPU Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 4
• DQMHistoTests: Total histograms compared: 19855
• DQMHistoTests: Total failures: 86
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 19769
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 3 files compared)
• Checked 12 log files, 9 edm output root files, 4 DQM output files
• TriggerResults: no differences found

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 3 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2787742
• DQMHistoTests: Total failures: 871
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2786870
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 37 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: no differences found

[perrotta]

@mariadalfonso the effect of the fix is not testable with the standard jenkins tests with "normal" inputs, of course.
Could you please confirm that you verified it actually fixes the cases that generated the issue?

[mariadalfonso]

@mariadalfonso the effect of the fix is not testable with the standard jenkins tests with "normal" inputs, of course.
Could you please confirm that you verified it actually fixes the cases that generated the issue?

I replicated the crash following instructions from here
#34197 (comment)
and the fix provided solve the crash for that particular configuration

[perrotta]

+reconstruction

• Verified to fix the HCAL and ECAL local reconstruction eon a GPU when any of those detectors is out
• The fix has no effect on the "normal" workflows when all detectors are present
• Since the issue showed up during MWGR, the already provided backport (HBHEGPU: protection when detector is out #34428) is welcome in 11_3

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy, @perrotta (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1