Protect HCAL GPU-related modules against empty events [12.0.x]

[fwyzard]

PR description:

Avoid running the HCAL local reconstruction if there are no HCAL digis - and set the size of the rechit collection to 0.

Avoid copying the rechits from the GPU to the CPU is their size is 0.

PR validation:

Running over data without HCAL no longer crashes.

PR status:

Backport of #34748.

[fwyzard]

type bugfix

[fwyzard]

backport of #34748

[fwyzard]

please test

[cmsbuild]

A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_12_0_X.

It involves the following packages:

• RecoLocalCalo/HcalRecProducers (reconstruction)

@perrotta, @jpata, @slava77 can you please review it and eventually sign? Thanks.
@apsallid, @mariadalfonso, @abdoulline, @bsunanda this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy, @perrotta you are the release manager for this.

cms-bot commands are listed here

• Backported from Protect HCAL GPU-related modules against empty events #34748

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bb9d30/17485/summary.html
COMMIT: 444c63e
CMSSW: CMSSW_12_0_X_2021-08-03-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34749/17485/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @fwyzard Fix integer division after migration to python 3 #34712

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bb9d30/17485/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bb9d30/17485/git-merge-result

RelVals-INPUT

• 11606.011606.0_SingleMuPt1+2021+SingleMuPt1_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA/step2_SingleMuPt1+2021+SingleMuPt1_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA.log
• 11601.011601.0_SingleElectronPt10+2021+SingleElectronPt10_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA/step2_SingleElectronPt10+2021+SingleElectronPt10_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA.log
• 11602.011602.0_SingleElectronPt35+2021+SingleElectronPt35_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA/step2_SingleElectronPt35+2021+SingleElectronPt35_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA.log

Expand to see more relval errors ...

• 11603.0
• 11604.0
• 11605.0
• 11607.0
• 11608.0
• 11609.0
• 11630.0
• 11634.0
• 11634.1
• 11634.24
• 11634.5
• 11634.501
• 11634.505
• 11634.511
• 11725.0
• 11634.521
• 11634.7
• 11634.91
• 11640.0
• 11643.0
• 11646.0
• 11650.0
• 11650.501
• 11650.505
• 11723.17
• 11834.0
• 11834.13
• 11834.24
• 11846.0
• 11925.0
• 12034.0
• 12434.0
• 12634.0
• 12834.0
• 13034.0
• 23434.21
• 23434.99
• 23434.9921
• 34834.21
• 34834.9921

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 9 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 2998564
• DQMHistoTests: Total failures: 18
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2998523
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 38 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[slava77]

+reconstruction

for #34749 444c63e

• code changes are the same as in the master variant Protect HCAL GPU-related modules against empty events #34748 9b37576
• jenkins tests pass and comparisons with the baseline show no relevant differences

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_0_X IBs (but tests are reportedly failing) and once validation in the development release cycle CMSSW_12_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy, @perrotta (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

• It was just merged in the master.However, it was already testes as being effective, also on hilton, and the fix is simple enough that it cannot harm the release in any case. Therefore, to speed up, I'm going to merge also this backport at once.

[perrotta]

merge