Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash of ECAL GPU reco when ECAL is out of the run - 12_0_X #34766

Merged
merged 2 commits into from
Aug 4, 2021
Merged

Fix crash of ECAL GPU reco when ECAL is out of the run - 12_0_X #34766

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d91fc4c
Fix crash of ECAL GPU reco when ECAL is out of the run.
thomreis Aug 4, 2021
2245ffb
Initialize the number of channels unconditionally.
thomreis Aug 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions EventFilter/EcalRawToDigi/plugins/EcalRawToDigiGPU.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,9 @@ void EcalRawToDigiGPU::acquire(edm::Event const& event,

// output cpu
outputCPU_ = {cms::cuda::make_host_unique<uint32_t[]>(2, ctx.stream())};
// initialize the number of channels
outputCPU_.nchannels[0] = 0;
outputCPU_.nchannels[1] = 0;

// output gpu
outputGPU_.allocate(config_, ctx.stream());
Expand Down
4 changes: 3 additions & 1 deletion RecoLocalCalo/EcalRecProducers/plugins/EcalUncalibRecHitProducerGPU.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,9 @@ void EcalUncalibRecHitProducerGPU::acquire(edm::Event const& event,

if ((neb_ > configParameters_.maxNumberHitsEB) || (nee_ > configParameters_.maxNumberHitsEE)) {
edm::LogError("EcalUncalibRecHitProducerGPU")
<< "max number of channels exceeded. See options 'maxNumberHitsEB and maxNumberHitsEE' ";
<< "Max number of channels exceeded in barrel or endcap. Number of barrel channels: " << neb_
<< " with maxNumberHitsEB=" << configParameters_.maxNumberHitsEB << ", number of endcap channels: " << nee_
<< " with maxNumberHitsEE=" << configParameters_.maxNumberHitsEE;
}

// conditions
Expand Down