[RFC] Add updated but "off" FastSim pixel resolution histograms infrastructure #34812

lcorcodilos · 2021-08-06T13:42:02Z

PR description:

This PR adds the infrastructure to use the FastSim pixel resolution histograms that were recently submitted to cms-data in this PR [1]. These are based on UL pixel simulation but will not be used in the UL FastSim production which has already begun.

This PR is just meant to preserve the work that was done and to make the new resolution histograms easily accessible in the future with the hard-coded boolean ULresolutionHistograms which is set to False. As result, this PR should produce no change.

[1] - cms-data/FastSimulation-TrackingRecHitProducer#4

Known issues/need for feedback

The new resolution histograms have been prepared for each year but the modifiers used to this point have been "per-phase". So in the case of Phase 1, the modifier needs to be different depending on the era. I currently have it coded as

    from Configuration.Eras.Era_Run2_2017_FastSim_cff import Run2_2017_FastSim
    Run2_2017_FastSim.toModify(fastTrackerRecHits, plugins = pixelPlugins2017UL)

    from Configuration.Eras.Era_Run2_2018_FastSim_cff import Run2_2018_FastSim
    Run2_2018_FastSim.toModify(fastTrackerRecHits, plugins = pixelPlugins2018UL)

but this obviously does not work - it just conveys the intention. We could use feedback on the best way to accomplish this implementation.

PR validation:

The following have been run successfully:

scram build code-checks
scram build code-format
scram b runtests

I also ran runTheMatrix.py -l limited -i all --ibeos but see failures that appear to be unrelated to these changes.

- Adds variable cotAlpha cotBeta bin widths

lcorcodilos · 2021-08-06T13:42:22Z

@tvami @pmaksim1 @sbein @OzAmram

tvami · 2021-08-06T13:47:19Z

@cmsbuild , please test with cms-data/FastSimulation-TrackingRecHitProducer#4

cmsbuild · 2021-08-06T13:47:34Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34812/24557

This PR adds an extra 28KB to repository
Found files with invalid states:
- FastSimulation/TrackingRecHitProducer/python/PixelPluginsUL_cfi.py:
  - Added: 5af2ea2
  - Modified: 3923132
  - Deleted: 1204004

cmsbuild · 2021-08-06T13:47:42Z

A new Pull Request was created by @lcorcodilos for master.

It involves the following packages:

FastSimulation/Configuration (fastsim)
FastSimulation/TrackingRecHitProducer (fastsim)

@lveldere, @civanch, @ssekmen, @mdhildreth, @sbein can you please review it and eventually sign? Thanks.
@matt-komm this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy, @perrotta you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2021-08-06T19:09:40Z

-1

Failed Tests: RelVals AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-295416/17613/summary.html
COMMIT: 1204004
CMSSW: CMSSW_12_1_X_2021-08-06-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34812/17613/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

135.4

----- Begin Fatal Exception 06-Aug-2021 20:09:01 CEST-----------------------
An exception of category 'FatalRootError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=TrackingRecHitProducer label='fastTrackerRecHits'
   Additional Info:
      [a] Fatal Root Error: @SUB=TArrayD::At
index 1 out of bounds (size: 0, this: 0x2b0d1cb514d0)

----- End Fatal Exception -------------------------------------------------

5.1

----- Begin Fatal Exception 06-Aug-2021 20:09:01 CEST-----------------------
An exception of category 'FatalRootError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=TrackingRecHitProducer label='fastTrackerRecHits'
   Additional Info:
      [a] Fatal Root Error: @SUB=TArrayD::At
index 1 out of bounds (size: 0, this: 0x2b1ea6b119d0)

----- End Fatal Exception -------------------------------------------------

AddOn Tests

fastsim

----- Begin Fatal Exception 06-Aug-2021 20:16:00 CEST-----------------------
An exception of category 'FatalRootError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=TrackingRecHitProducer label='fastTrackerRecHits'
   Additional Info:
      [a] Fatal Root Error: @SUB=TArrayD::At
index 1 out of bounds (size: 0, this: 0x2b2f475f6ad0)

----- End Fatal Exception -------------------------------------------------

fastsim1

----- Begin Fatal Exception 06-Aug-2021 20:16:02 CEST-----------------------
An exception of category 'FatalRootError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=TrackingRecHitProducer label='fastTrackerRecHits'
   Additional Info:
      [a] Fatal Root Error: @SUB=TArrayD::At
index 1 out of bounds (size: 0, this: 0x2b87543f4ad0)

----- End Fatal Exception -------------------------------------------------

fastsim2

----- Begin Fatal Exception 06-Aug-2021 20:16:00 CEST-----------------------
An exception of category 'FatalRootError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=TrackingRecHitProducer label='fastTrackerRecHits'
   Additional Info:
      [a] Fatal Root Error: @SUB=TArrayD::At
index 1 out of bounds (size: 0, this: 0x2b6f9fc715d0)

----- End Fatal Exception -------------------------------------------------

lcorcodilos · 2021-08-06T19:17:16Z

I'll copy one of these tests and try to debug what's going on. Based on the changes, my suspicion is that something is going on in PixelResolutionHistograms.cc/h

tvami · 2022-07-10T21:42:41Z

Hmmm the results in #34812 (comment) dont match my recollection... my recollection was that in the end we started seeing result in the central wf-s, like 5.1 but now everything upto MsgLogger looks fine. Is that now just the trick with the stats? Or the point is that in the PR the feature now is disabled by default?

tvami · 2022-07-10T21:44:08Z

the hard-coded boolean ULresolutionHistograms which is set to False. As result, this PR should produce no change.

ahh yes, ok, so the point indeed is that in the PR the feature now is disabled by default

sbein · 2022-07-11T10:19:51Z

Yes, the ULresolutionHistograms booleans basically suppress all impact until someone can come and figure out why the enabled feature causes significant changes to physics observables, e.g., @pmaksim1 and company.

tvami · 2022-07-11T10:24:27Z

t until someone can come and figure out why the enabled feature causes significant changes to physics observables, e.g., pmaksim1 and company.

Yes, we have somebody starting to work on it, @ammitra

smuzaffar · 2023-11-06T16:49:06Z

Milestone for this pull request has been moved to CMSSW_14_0_X.Please open a backport if it should also go in to CMSSW_13_3_X.

tvami · 2023-11-06T16:55:45Z

@cmsbuild , please close

Lucas left the field, there are several things to debug, a new PR can be opened when those issues are resolved

cmsbuild · 2023-11-06T20:31:59Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-295416/35633/summary.html
COMMIT: 081af5b
CMSSW: CMSSW_13_3_X_2023-11-06-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34812/35633/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

@smuzaffar Use likelihood fit instead of chi-square fit for PFJetDQMPostProcessor plugin #43170
@fabiocos MTD geometry: speed up MTD reco geometry construction #43124
@bsunanda Phase2-hgx348A Make use of constexpr in the scintillator DeId for HGCal for better processing #43167
@bsunanda Phase2-hgx348B Take care of handling both HGCal and HFNose access to Geometry and Topology classes #43194

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-295416/35633/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-295416/35633/git-merge-result

Comparison Summary

Summary:

You potentially removed 98 lines from the logs
Reco comparison results: 5 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 3363010
DQMHistoTests: Total failures: 1214
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3361774
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
Checked 214 log files, 167 edm output root files, 50 DQM output files
TriggerResults: no differences found

lcorcodilos added 11 commits August 4, 2021 11:10

Add initial PixelPluginsUL_cfi.py draft

5af2ea2

Use new UL resolution histos

2f964cd

Add PixelResolutionHistograms changes

c6ca728

- Adds variable cotAlpha cotBeta bin widths

Add flag instead of commented code

d8ad701

Create two EDProducers instead

a506c43

Add 2016 plaq/module select

3923132

Fix PRH compile errors

e26e4d0

Go back to using hard-coded bool

10a80b9

Revert Reconstruction_BefMix changes

0feaf1d

Move to individual cfi files

0bd7f69

Code style changes

1204004

cmsbuild added this to the CMSSW_12_1_X milestone Aug 6, 2021

cmsbuild added code-checks-pending fastsim-pending orp-pending pending-signatures tests-pending labels Aug 6, 2021

cmsbuild added code-checks-approved requires-external tests-started and removed tests-pending code-checks-pending labels Aug 6, 2021

cmsbuild added tests-rejected and removed tests-started labels Aug 6, 2021

cmsbuild added the tests-approved label Jul 10, 2022

smuzaffar modified the milestones: CMSSW_12_5_X, CMSSW_12_6_X Aug 28, 2022

cmsbuild modified the milestones: CMSSW_12_6_X, CMSSW_13_0_X Nov 24, 2022

smuzaffar modified the milestones: CMSSW_13_0_X, CMSSW_13_1_X Feb 11, 2023

smuzaffar modified the milestones: CMSSW_13_1_X, CMSSW_13_2_X May 4, 2023

smuzaffar modified the milestones: CMSSW_13_2_X, CMSSW_13_3_X Jul 18, 2023

cmsbuild mentioned this pull request Aug 8, 2023

Moved creating SiPixelTemplateStore from DB to an ESProducer #42514

Merged

cmsbuild mentioned this pull request Aug 17, 2023

Do not use a Task with SiPixelTemplateStoreESProducer #42597

Merged

smuzaffar modified the milestones: CMSSW_13_3_X, CMSSW_14_0_X Nov 6, 2023

cmsbuild modified the milestones: CMSSW_14_0_X, CMSSW_13_3_X Nov 6, 2023

cmsbuild added tests-started tracking and removed tests-approved labels Nov 6, 2023

cmsbuild closed this Nov 6, 2023

cmsbuild added tests-approved and removed tests-started labels Nov 6, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[RFC] Add updated but "off" FastSim pixel resolution histograms infrastructure #34812

[RFC] Add updated but "off" FastSim pixel resolution histograms infrastructure #34812

lcorcodilos commented Aug 6, 2021

lcorcodilos commented Aug 6, 2021

tvami commented Aug 6, 2021

cmsbuild commented Aug 6, 2021

cmsbuild commented Aug 6, 2021

cmsbuild commented Aug 6, 2021

lcorcodilos commented Aug 6, 2021

tvami commented Jul 10, 2022

tvami commented Jul 10, 2022

sbein commented Jul 11, 2022 •

edited

Loading

tvami commented Jul 11, 2022

smuzaffar commented Nov 6, 2023

tvami commented Nov 6, 2023

cmsbuild commented Nov 6, 2023

[RFC] Add updated but "off" FastSim pixel resolution histograms infrastructure #34812

[RFC] Add updated but "off" FastSim pixel resolution histograms infrastructure #34812

Conversation

lcorcodilos commented Aug 6, 2021

PR description:

Known issues/need for feedback

PR validation:

lcorcodilos commented Aug 6, 2021

tvami commented Aug 6, 2021

cmsbuild commented Aug 6, 2021

cmsbuild commented Aug 6, 2021

cmsbuild commented Aug 6, 2021

RelVals

AddOn Tests

lcorcodilos commented Aug 6, 2021

tvami commented Jul 10, 2022

tvami commented Jul 10, 2022

sbein commented Jul 11, 2022 • edited Loading

tvami commented Jul 11, 2022

smuzaffar commented Nov 6, 2023

tvami commented Nov 6, 2023

cmsbuild commented Nov 6, 2023

Comparison Summary

sbein commented Jul 11, 2022 •

edited

Loading