Add new reco::Muon 'displacedMuons' collection to AOD #36926

CeliaFernandez · 2022-02-10T13:08:51Z

PR description:

This PR adds a new reco::Muon collection, called 'displacedMuons', that includes the dedicated displaced muon reconstructions: 'displacedTracks', 'displacedGlobalMuons' and 'displacedStandAloneMuons' (all of them saved in AOD as reco::Track collections).

In this PR we add the necessary modifications to:

Cross-clean the existing reco::Track objects in order to avoid the duplication or loss of displaced muon candidates in the output collection.
Compute the main muon variables, including isolation, time, recoTracksExtras... etc
Save this information in AOD and RECO, as configured for standard 'muons' collection

The sequences are implemented to run independently to the default reco::Muon 'muons' collection and avoid interferences. Muons of the 'muons' collection should remain untouchable. They also emulate the existing implementation and make use of the existing tools and sequences so the new information is computed with the default parameters configuration.

The following packages are modified:

RecoMuon/Configuration: To perform the cross-cleaning (in RecoMuonPPOnly), integrate the new displaced sequences (RecoMuon_cff.py) and define the information saved in AOD (RecoMuon_EventContent_cff.py)
RecoMuon/Identification: To define the main 'displacedMuons' sequence for the new collection (displacedMuons_cfi.py) and the sequence to compute the ReducedTrackExtras associated to it (displacedMuonsReducedTrackExtras_cfi.py)
RecoMuon/MuonIsolationProducers: To add the detector-based isolation deposits (muIsolation_cff.py, muIsoDeposits_cff.py, muIsoDepositCopies_cfi.py and muIsolation_EventContent_cff.py)
RecoMuon/MuonIsolation: To add the PFIsolation (muonPFIsolation_cff.py, displacedMuonPFIsolationValues_cff.py and displacedMuonPFIsolationDeposits_cff.py)

The increase in size was measured by using a ttbar benchmark model (runTheMatrix.py workflow 11634.0), where we obtained a relative increase of the 1.23%

Backup documentation, detailed information about the modifications and validation can be found here: https://cernbox.cern.ch/index.php/s/FfAZonfSest7kqQ

The implementation was built on top of CMSSW_12_3_0_pre2

@gkaratha @sscruz @trocino

PR validation:

We have checked out all dependencies and have a clean build.
The actions defined in the new sequences were validated and these results are presented in the backup documentation:
https://cernbox.cern.ch/index.php/s/FfAZonfSest7kqQ

…splacedStandAloneMuons to create a recoMuon collection with MuonReducedTrackExtras

…CO now but not in AOD, remove unecessary producers.

cmsbuild · 2022-02-10T13:15:42Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36926/28246

This PR adds an extra 24KB to repository

cmsbuild · 2022-02-10T13:16:10Z

A new Pull Request was created by @CeliaFernandez (Celia Fernández Madrazo) for master.

It involves the following packages:

RecoMuon/Configuration (reconstruction)
RecoMuon/MuonIdentification (reconstruction)
RecoMuon/MuonIsolation (reconstruction)
RecoMuon/MuonIsolationProducers (reconstruction)

@jpata, @cmsbuild, @clacaputo, @slava77 can you please review it and eventually sign? Thanks.
@HuguesBrun, @bellan, @abbiendi, @Fedespring, @calderona, @sscruz, @jhgoh, @trocino, @cericeci, @rociovilar this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

clacaputo · 2022-02-10T16:44:53Z

@cmsbuild please test

cmsbuild · 2022-02-10T18:11:15Z

-1

Failed Tests: RelVals AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e70a53/22338/summary.html
COMMIT: 25764ce
CMSSW: CMSSW_12_3_X_2022-02-10-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36926/22338/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

135.4

----- Begin Fatal Exception 10-Feb-2022 17:13:30 UTC-----------------------
An exception of category 'FatalError' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'FEVTDEBUGHLToutput_step'
   [2] Prefetching for module PoolOutputModule/'FEVTDEBUGHLToutput'
   [3] Prefetching for module MuonReducedTrackExtraProducer/'displacedMuonReducedTrackExtras'
   [4] Prefetching for module MuonProducer/'displacedMuons'
   [5] Calling method for module MuonIdProducer/'displacedMuons1stStep'
Exception Message:
Failed to get input track collection with label: InputTag:  label = displacedTracks, instance = 
----- End Fatal Exception -------------------------------------------------

5.1

----- Begin Fatal Exception 10-Feb-2022 17:13:32 UTC-----------------------
An exception of category 'FatalError' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'FEVTDEBUGHLToutput_step'
   [2] Prefetching for module PoolOutputModule/'FEVTDEBUGHLToutput'
   [3] Prefetching for module MuonReducedTrackExtraProducer/'displacedMuonReducedTrackExtras'
   [4] Prefetching for module MuonProducer/'displacedMuons'
   [5] Calling method for module MuonIdProducer/'displacedMuons1stStep'
Exception Message:
Failed to get input track collection with label: InputTag:  label = displacedTracks, instance = 
----- End Fatal Exception -------------------------------------------------

2018.1

----- Begin Fatal Exception 10-Feb-2022 17:14:49 UTC-----------------------
An exception of category 'FatalError' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'FEVTDEBUGHLToutput_step'
   [2] Prefetching for module PoolOutputModule/'FEVTDEBUGHLToutput'
   [3] Prefetching for module MuonReducedTrackExtraProducer/'displacedMuonReducedTrackExtras'
   [4] Prefetching for module MuonProducer/'displacedMuons'
   [5] Calling method for module MuonIdProducer/'displacedMuons1stStep'
Exception Message:
Failed to get input track collection with label: InputTag:  label = displacedTracks, instance = 
----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

AddOn Tests

fastsim

----- Begin Fatal Exception 10-Feb-2022 17:11:39 UTC-----------------------
An exception of category 'FatalError' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 3
   [1] Running path 'AODSIMoutput_step'
   [2] Prefetching for module PoolOutputModule/'AODSIMoutput'
   [3] Prefetching for module MuonReducedTrackExtraProducer/'displacedMuonReducedTrackExtras'
   [4] Prefetching for module MuonProducer/'displacedMuons'
   [5] Calling method for module MuonIdProducer/'displacedMuons1stStep'
Exception Message:
Failed to get input track collection with label: InputTag:  label = displacedTracks, instance = 
----- End Fatal Exception -------------------------------------------------

fastsim1

----- Begin Fatal Exception 10-Feb-2022 17:11:07 UTC-----------------------
An exception of category 'FatalError' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 3
   [1] Running path 'AODSIMoutput_step'
   [2] Prefetching for module PoolOutputModule/'AODSIMoutput'
   [3] Prefetching for module MuonReducedTrackExtraProducer/'displacedMuonReducedTrackExtras'
   [4] Prefetching for module MuonProducer/'displacedMuons'
   [5] Calling method for module MuonIdProducer/'displacedMuons1stStep'
Exception Message:
Failed to get input track collection with label: InputTag:  label = displacedTracks, instance = 
----- End Fatal Exception -------------------------------------------------

fastsim2

----- Begin Fatal Exception 10-Feb-2022 17:11:51 UTC-----------------------
An exception of category 'FatalError' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 3 stream: 1
   [1] Running path 'AODSIMoutput_step'
   [2] Prefetching for module PoolOutputModule/'AODSIMoutput'
   [3] Prefetching for module MuonReducedTrackExtraProducer/'displacedMuonReducedTrackExtras'
   [4] Prefetching for module MuonProducer/'displacedMuons'
   [5] Calling method for module MuonIdProducer/'displacedMuons1stStep'
Exception Message:
Failed to get input track collection with label: InputTag:  label = displacedTracks, instance = 
----- End Fatal Exception -------------------------------------------------

…onstruction is not available there

cmsbuild · 2022-02-11T14:21:29Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36926/28271

This PR adds an extra 28KB to repository

cmsbuild · 2022-02-11T14:21:51Z

Pull request #36926 was updated. @jpata, @cmsbuild, @clacaputo, @slava77 can you please check and sign again.

clacaputo · 2022-02-11T13:45:14Z

RecoMuon/MuonIdentification/python/displacedMuons_cfi.py

@@ -0,0 +1,103 @@
+# This file name is temporary and ment for development only.


Maybe these two lines are outdated. If so, could you remove them?

clacaputo · 2022-02-11T14:11:12Z

RecoMuon/Configuration/python/RecoMuon_EventContent_cff.py

@@ -36,6 +36,15 @@
                                           #'drop *_muons_muons1stStep2muonsMap_*',
                                           #'drop recoIsoDepositedmValueMap_muons_*_*', #not really used
                                           #'drop doubleedmValueMap_muons_muPFIso*_*', #already inside the muon
+                                           # displacedMuons collection
+                                           'keep recoMuons_displacedMuons_*_*',


Do you know what is the contribution to the total size increase given by each of these new collections?

We have computed it in a ttbar sample (runTheMatrix.py workflow 11634.0). The table with the size increase is in slide 28 of this presentation: https://cernbox.cern.ch/index.php/s/FfAZonfSest7kqQ

cmsbuild · 2022-02-14T22:45:56Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e70a53/22411/summary.html
COMMIT: 4d2de56
CMSSW: CMSSW_12_3_X_2022-02-13-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36926/22411/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 7 differences found in the comparisons
DQMHistoTests: Total files compared: 46
DQMHistoTests: Total histograms compared: 3764435
DQMHistoTests: Total failures: 13
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 3764399
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.004 KiB( 45 files compared)
DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
Checked 193 log files, 42 edm output root files, 46 DQM output files
TriggerResults: no differences found

jpata · 2022-02-18T15:17:39Z

what's the overall cost of the 1.2% AOD increase for CMS? how much AOD is planned to be saved with this feature? how much less MC stats does this size increase imply?
what's the runtime and memory increase of this PR?
are all the variables in the new collection always meaningful? e.g. for low-pt muons, can you omit some variables?

clacaputo · 2022-02-21T15:28:36Z

test parameters:

enable_test = profiling

jpata · 2022-02-21T15:30:08Z

what's the overall cost of the 1.2% AOD increase for CMS? how much AOD is planned to be saved with this feature? how much less MC stats does this size increase imply?

after discussing with David and Danilo:

1.2% bigger AOD means 1.2% less MC stats for CMS overall. There is obviously some physics decision here, with more analyses being possible, but all other analyses potentially suffering a bit. This may be a PC-level decision. The best we can do from the proponents&reco side is to ensure that the increase is as small as reasonably possible.
If we can find a way to reduce by the corresponding amount somewhere else in AOD (e.g. CPU and disk optimization: TrackExtrapolator #30968), the decision may be easier to take

clacaputo · 2022-02-21T15:32:21Z

@cmsbuild please test

cmsbuild · 2022-02-21T21:50:05Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e70a53/22551/summary.html
COMMIT: 4d2de56
CMSSW: CMSSW_12_3_X_2022-02-21-1100/slc7_amd64_gcc10
Additional Tests: PROFILING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36926/22551/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 1 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3965143
DQMHistoTests: Total failures: 2
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3965119
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
Checked 204 log files, 45 edm output root files, 49 DQM output files
TriggerResults: no differences found

clacaputo · 2022-02-22T12:36:40Z

edmEventSize comparison AOD output for wf 11834.21 indicate an increase of 2.2% related to the new collections introduced.
@CeliaFernandez on how many events did you perform the check?

Just for reference:

Checking process _ step3_sizes_CMSSW_12_3_X_2022-02-21-1100_11834.21.txt and step3_sizes_11834.21.txt with useUnpacked=no (if above 100 or 10%):
Compare packed values
-----------------------------------------------------------------
   or, B         new, B      delta, B   delta, %   deltaJ, %    branch 
-----------------------------------------------------------------
      0.0 ->       174.2        174     NEWO   0.01     doubleedmValueMap_displacedMuons_dispMuPFMeanDRIsoValueGammaHighThreshold04_RECO.
      0.0 ->       174.8        175     NEWO   0.01     doubleedmValueMap_displacedMuons_dispMuPFMeanDRIsoValuePU04_RECO.
      0.0 ->       488.2        488     NEWO   0.04     TrackingRecHitsOwned_displacedMuonReducedTrackExtras__RECO.
      0.0 ->       165.8        166     NEWO   0.01     doubleedmValueMap_displacedMuons_dispMuPFSumDRIsoValueCharged03_RECO.
      0.0 ->       171.4        171     NEWO   0.01     doubleedmValueMap_displacedMuons_dispMuPFMeanDRIsoValueChargedAll03_RECO.
      0.0 ->       170.4        170     NEWO   0.01     doubleedmValueMap_displacedMuons_dispMuPFMeanDRIsoValueGammaHighThreshold03_RECO.
      0.0 ->       169.8        170     NEWO   0.01     doubleedmValueMap_displacedMuons_dispMuPFMeanDRIsoValueGamma04_RECO.
      0.0 ->       167.8        168     NEWO   0.01     doubleedmValueMap_displacedMuons_dispMuPFSumDRIsoValueNeutral04_RECO.
      0.0 ->       174.2        174     NEWO   0.01     doubleedmValueMap_displacedMuons_dispMuPFMeanDRIsoValuePU03_RECO.
      0.0 ->      1622.4       1622     NEWO   0.14     recoMuonTimeExtraedmValueMap_displacedMuons_csc_RECO.
      0.0 ->       170.6        171     NEWO   0.01     doubleedmValueMap_displacedMuons_dispMuPFMeanDRIsoValueCharged04_RECO.
      0.0 ->       169.3        169     NEWO   0.01     doubleedmValueMap_displacedMuons_dispMuPFSumDRIsoValuePU04_RECO.
      0.0 ->       166.2        166     NEWO   0.01     doubleedmValueMap_displacedMuons_dispMuPFMeanDRIsoValueGamma03_RECO.
      0.0 ->       165.2        165     NEWO   0.01     doubleedmValueMap_displacedMuons_dispMuPFSumDRIsoValueNeutral03_RECO.
      0.0 ->       176.1        176     NEWO   0.01     doubleedmValueMap_displacedMuons_dispMuPFMeanDRIsoValueNeutralHighThreshold04_RECO.
      0.0 ->       167.8        168     NEWO   0.01     doubleedmValueMap_displacedMuons_dispMuPFMeanDRIsoValueCharged03_RECO.
      0.0 ->      1275.5       1276     NEWO   0.11     SiStripClusteredmNewDetSetVector_displacedMuonReducedTrackExtras__RECO.
      0.0 ->      1679.0       1679     NEWO   0.14     recoMuonTimeExtraedmValueMap_displacedMuons_combined_RECO.
      0.0 ->      1657.8       1658     NEWO   0.14     SiPixelClusteredmNewDetSetVector_displacedMuonReducedTrackExtras__RECO.
      0.0 ->       172.8        173     NEWO   0.01     doubleedmValueMap_displacedMuons_dispMuPFSumDRIsoValueGammaHighThreshold04_RECO.
      0.0 ->       168.8        169     NEWO   0.01     doubleedmValueMap_displacedMuons_dispMuPFSumDRIsoValuePU03_RECO.
      0.0 ->      1873.0       1873     NEWO   0.16     recoTrackExtras_displacedMuonReducedTrackExtras__RECO.
      0.0 ->       172.1        172     NEWO   0.01     doubleedmValueMap_displacedMuons_dispMuPFMeanDRIsoValueNeutralHighThreshold03_RECO.
      0.0 ->       167.2        167     NEWO   0.01     doubleedmValueMap_displacedMuons_dispMuPFSumDRIsoValueGamma04_RECO.
      0.0 ->       171.2        171     NEWO   0.01     doubleedmValueMap_displacedMuons_dispMuPFSumDRIsoValueChargedAll04_RECO.
      0.0 ->       175.2        175     NEWO   0.01     doubleedmValueMap_displacedMuons_dispMuPFSumDRIsoValueNeutralHighThreshold04_RECO.
      0.0 ->       169.2        169     NEWO   0.01     doubleedmValueMap_displacedMuons_dispMuPFSumDRIsoValueGammaHighThreshold03_RECO.
      0.0 ->       168.2        168     NEWO   0.01     doubleedmValueMap_displacedMuons_dispMuPFSumDRIsoValueCharged04_RECO.
      0.0 ->     10148.0      10148     NEWO   0.86     recoMuons_displacedMuons__RECO.
      0.0 ->       168.9        169     NEWO   0.01     doubleedmValueMap_displacedMuons_dispMuPFMeanDRIsoValueNeutral04_RECO.
      0.0 ->       173.4        173     NEWO   0.01     doubleedmValueMap_displacedMuons_dispMuPFMeanDRIsoValueChargedAll04_RECO.
      0.0 ->       171.3        171     NEWO   0.01     doubleedmValueMap_displacedMuons_dispMuPFSumDRIsoValueNeutralHighThreshold03_RECO.
      0.0 ->      1565.8       1566     NEWO   0.13     recoMuonTimeExtraedmValueMap_displacedMuons_dt_RECO.
      0.0 ->      1110.3       1110     NEWO   0.09     recoTrackExtrasedmAssociation_displacedMuonReducedTrackExtras__RECO.
      0.0 ->       164.7        165     NEWO   0.01     doubleedmValueMap_displacedMuons_dispMuPFSumDRIsoValueGamma03_RECO.
      0.0 ->       168.8        169     NEWO   0.01     doubleedmValueMap_displacedMuons_dispMuPFSumDRIsoValueChargedAll03_RECO.
      0.0 ->       166.2        166     NEWO   0.01     doubleedmValueMap_displacedMuons_dispMuPFMeanDRIsoValueNeutral03_RECO.
-------------------------------------------------------------
  1181014 ->     1207192      26179             2.2     ALL BRANCHES

CeliaFernandez · 2022-02-22T13:48:08Z

I checked with very reduced statistics, 2000-2500 events.

clacaputo · 2022-02-23T15:31:19Z

Hi @CeliaFernandez , could you please check the size increase on wf 11834.21 with the statistics that you have stated here #36926 (comment)?
Thanks

CeliaFernandez · 2022-03-01T17:48:04Z

Hi @clacaputo , I'm working on checking the size increase with the mentioned workflow. However, I have seen that when I run it I get several warning/error messages which I'm not pretty sure if they come from the implementation, the workflow itself or some bad configuration that I'm setting... For example, for step 3 (the one mentioned above):

%MSG-w TrackNaN: TrackProducer:pixelLessStepTracks 01-Mar-2022 18:34:17 CET Run: 1 Event: 3
Track has NaN or the cov is not pos-definite
%MSG
%MSG-w BasicTrajectoryState: MkFitOutputConverter:pixelLessStepTrackCandidates 01-Mar-2022 18:34:27 CET Run: 1 Event: 5
local error not pos-def
[ 8.60678e-07 1.75447e-09 1.00676e-06 3.26687e-07-8.93862e-07
1.75447e-09-1.29687e-08-1.59311e-07-3.21759e-08-1.45759e-07
1.00676e-06-1.59311e-07 3.38469e-06 1.80004e-06 9.90766e-06
3.26687e-07-3.21759e-08 1.80004e-06 4.32012e-06-2.41421e-05
-8.93862e-07-1.45759e-07 9.90766e-06-2.41421e-05 0.00127064 ]
pos/mom/mf (-28.4537,-19.378,-90.6192) (-1.36899,-0.722564,-7.87008) (0.00539667,0.00367532,3.7947)

I got this for most of the events... Is this normal?
Thanks!

jpata · 2022-03-01T18:46:20Z

this is a known issue #35798 and should not affect your studies

CeliaFernandez · 2022-03-07T15:58:36Z

I compute the sizes again with the 11834.21 workflow. I did it with 1k events, which is the number used to compute the numbers above (I revisited the computation and I found that only 1k events were used), and also with a total of 16k which is the number of events we produced to obtain the validation plots. For the 1k sample I obtain a +1% relative increase, and with the 16k sample, a +0.97% relative increase. These numbers doesn't match with yours... Maybe we are missing something and we are underestimating the increase in size?

We are computing these numbers with the methods provided in printSizes.C macro, that you can find here: https://root.cern/doc/v610/printSizes_8C_source.html
The measurement is done with respect to the tree stored inside the root file, not the root file itself...

I also attach 2 txt files with the space taken by each branch in case you want to check:
info_1k.txt
info_15974.txt

clacaputo · 2022-03-08T15:09:26Z

Hi @CeliaFernandez , thanks for having performed the measurement using 11834.21. I'm inclined to consider your result more indicative, considering the statistics that you have used, while the one obtained by cmstest has less stat and therefore the compression is still not visible.
If you have the files somewhere, I can definitely repeat the measurement, although printSizes.C seems appropriate.

So, considering that the size increase is ~1 there is still open the point made by Joosep (#36926 (comment))

1.2% bigger AOD means 1.2% less MC stats for CMS overall. There is obviously some physics decision here, with more analyses being possible, but all other analyses potentially suffering a bit. This may be a PC-level decision. The best we can do from the proponents&reco side is to ensure that the increase is as small as reasonably possible.

Did @cms-sw/muon-pog-l2 have the chance to start a discussion with EXO ?

CeliaFernandez · 2022-03-08T16:16:10Z

Not yet, we will start the discussion soon. In this moment we are developing a filter that will reduce the increase by removing overlapping muons with standard 'muons' collection. If the filter is efficient, we will also estimate the increase in MiniAOD to see if it is doable to extend the implementation there.

In case you want to do a quick estimate, one file is available here:
/afs/cern.ch/work/f/fernance/public/displacedMuons/AOD-samples-11834

jpata · 2022-04-29T12:56:59Z

type muon

jpata · 2022-05-05T10:20:37Z

since you opened #37805, can you close this one here?

CeliaFernandez added 2 commits January 31, 2022 12:53

Add sequences to process displacedTracks, displacedGlobalMuons and di…

e90cc2e

…splacedStandAloneMuons to create a recoMuon collection with MuonReducedTrackExtras

Modify detector based isolation processing: Deposits only saved in RE…

25764ce

…CO now but not in AOD, remove unecessary producers.

cmsbuild added this to the CMSSW_12_3_X milestone Feb 10, 2022

cmsbuild added code-checks-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Feb 10, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 10, 2022

cmsbuild added tests-started and removed tests-pending labels Feb 10, 2022

cmsbuild added tests-rejected and removed tests-started labels Feb 10, 2022

Remove displacedMuons sequences from fastsim since displacedTrack rec…

0c974b0

…onstruction is not available there

cmsbuild added code-checks-pending tests-pending and removed tests-rejected code-checks-approved labels Feb 11, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 11, 2022

clacaputo reviewed Feb 11, 2022

View reviewed changes

Remove outdated lines

0e2664c

cmsbuild removed the code-checks-approved label Feb 11, 2022

cmsbuild added tests-started and removed tests-pending labels Feb 14, 2022

cmsbuild added tests-approved and removed tests-started labels Feb 14, 2022

cmsbuild added tests-started and removed tests-approved labels Feb 21, 2022

cmsbuild added tests-approved and removed tests-started labels Feb 21, 2022

smuzaffar modified the milestones: CMSSW_12_3_X, CMSSW_12_4_X Mar 11, 2022

mariadalfonso mentioned this pull request Apr 21, 2022

Add the displaced muon collection cms-nanoAOD/cmssw#597

Open

cmsbuild added the muon label Apr 29, 2022

CeliaFernandez mentioned this pull request May 4, 2022

Add new reco::Muon 'displacedMuons' collection to AOD and MiniAOD #37805

Merged

CeliaFernandez closed this May 5, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add new reco::Muon 'displacedMuons' collection to AOD #36926

Add new reco::Muon 'displacedMuons' collection to AOD #36926

CeliaFernandez commented Feb 10, 2022 •

edited

Loading

cmsbuild commented Feb 10, 2022

cmsbuild commented Feb 10, 2022

clacaputo commented Feb 10, 2022

cmsbuild commented Feb 10, 2022

cmsbuild commented Feb 11, 2022

cmsbuild commented Feb 11, 2022

clacaputo Feb 11, 2022

clacaputo Feb 11, 2022

CeliaFernandez Feb 11, 2022 •

edited

Loading

cmsbuild commented Feb 14, 2022

jpata commented Feb 18, 2022 •

edited

Loading

clacaputo commented Feb 21, 2022

jpata commented Feb 21, 2022 •

edited

Loading

clacaputo commented Feb 21, 2022

cmsbuild commented Feb 21, 2022

clacaputo commented Feb 22, 2022

CeliaFernandez commented Feb 22, 2022

clacaputo commented Feb 23, 2022

CeliaFernandez commented Mar 1, 2022 •

edited

Loading

jpata commented Mar 1, 2022

CeliaFernandez commented Mar 7, 2022

clacaputo commented Mar 8, 2022 •

edited

Loading

CeliaFernandez commented Mar 8, 2022

jpata commented Apr 29, 2022

jpata commented May 5, 2022

		@@ -0,0 +1,103 @@
		# This file name is temporary and ment for development only.

Add new reco::Muon 'displacedMuons' collection to AOD #36926

Add new reco::Muon 'displacedMuons' collection to AOD #36926

Conversation

CeliaFernandez commented Feb 10, 2022 • edited Loading

PR description:

PR validation:

cmsbuild commented Feb 10, 2022

cmsbuild commented Feb 10, 2022

clacaputo commented Feb 10, 2022

cmsbuild commented Feb 10, 2022

RelVals

AddOn Tests

cmsbuild commented Feb 11, 2022

cmsbuild commented Feb 11, 2022

clacaputo Feb 11, 2022

Choose a reason for hiding this comment

clacaputo Feb 11, 2022

Choose a reason for hiding this comment

CeliaFernandez Feb 11, 2022 • edited Loading

Choose a reason for hiding this comment

cmsbuild commented Feb 14, 2022

Comparison Summary

jpata commented Feb 18, 2022 • edited Loading

clacaputo commented Feb 21, 2022

jpata commented Feb 21, 2022 • edited Loading

clacaputo commented Feb 21, 2022

cmsbuild commented Feb 21, 2022

Comparison Summary

clacaputo commented Feb 22, 2022

CeliaFernandez commented Feb 22, 2022

clacaputo commented Feb 23, 2022

CeliaFernandez commented Mar 1, 2022 • edited Loading

jpata commented Mar 1, 2022

CeliaFernandez commented Mar 7, 2022

clacaputo commented Mar 8, 2022 • edited Loading

CeliaFernandez commented Mar 8, 2022

jpata commented Apr 29, 2022

jpata commented May 5, 2022

CeliaFernandez commented Feb 10, 2022 •

edited

Loading

CeliaFernandez Feb 11, 2022 •

edited

Loading

jpata commented Feb 18, 2022 •

edited

Loading

jpata commented Feb 21, 2022 •

edited

Loading

CeliaFernandez commented Mar 1, 2022 •

edited

Loading

clacaputo commented Mar 8, 2022 •

edited

Loading