-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for L1T-MuonShowers as trigger objects at HLT #36951
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36951/28303
|
A new Pull Request was created by @missirol (Marino Missiroli) for master. It involves the following packages:
@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bb26dd/22393/summary.html Comparison SummarySummary:
|
@missirol |
Hi Martin, yes. I have nothing to add to this PR. |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
#include "DataFormats/L1Trigger/interface/L1MuonParticle.h" | ||
#include "DataFormats/L1Trigger/interface/L1EtMissParticle.h" | ||
|
||
#include "DataFormats/L1Trigger/interface/L1HFRings.h" // deprecate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does "deprecate" mean that they can be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No: it means they are deprectated by L1 in favor of L1T stage-2 objects, but still available in CMSSW and HLT for b/w compatibility.
+1 |
PR description:
This PR adds support for the Run-3 "MuonShower" L1T objects (introduced in #33446 and #36018) in the DataFormats, producers and analysers used by HLT to write and read trigger objects.
Beyond the L1T MuonShowers use case, the update of
HLTEventAnalyzerRAW
also adds support for other L1T objects that were previously not considered in that plugin (following the ordering inTriggerRefsCollections
).PR validation:
Validated with a user recipe (provided by @kakwok, see description of Set receiveMuShower =true for uGT #36929) using new L1T seeds based on L1T-MuonShowers.
addOnTests.py
passed.If this PR is a backport, please specify the original PR and why you need to backport that PR:
N/A