Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the relevant variable for BDT based beam halo tagger for photons in nanoAOD #38850

Merged
merged 1 commit into from
Jul 26, 2022

Conversation

jainshilpi
Copy link
Contributor

This PR adds the value of MVA score of the BDT based beam halo tagger (for the EE) for photons in the nanoAOD. Relevant PR where it was merged in miniAOD: #36901

Backport will also be created in another PR.

@mariadalfonso

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38850/31241

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @jainshilpi for master.

It involves the following packages:

  • PhysicsTools/NanoAOD (xpog)

@cmsbuild, @mariadalfonso, @gouskos, @fgolf can you please review it and eventually sign? Thanks.
@gpetruc, @swertz this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mariadalfonso
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-09e8d1/26440/summary.html
COMMIT: 58de769
CMSSW: CMSSW_12_5_X_2022-07-25-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38850/26440/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 60 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3667670
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3667646
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 210 log files, 47 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@mariadalfonso
Copy link
Contributor

  • Reco comparison results: 60 differences found in the comparisons

these difference shows up just because we added one and all the branches are different

https://cms-nanoaod-integration.web.cern.ch/integration/cms-swmaster38850/mc123Xrun3_size_report.html#Photon
Photon (1.4 items/evt, 0.112 kb/evt)

The new branch is

branch kind b/event b/item plot %
Photon_haloTaggerMVAVal | Float_t | 1.3 | 0.9 |   | 1.2%

@mariadalfonso
Copy link
Contributor

+xpog

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Jul 26, 2022

+1

@cmsbuild cmsbuild merged commit d13385b into cms-sw:master Jul 26, 2022
cmsbuild added a commit that referenced this pull request Jul 27, 2022
Backport of #38850: Adding the relevant variable for BDT based beam halo tagger for photons in nanoAOD
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants