-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing dependencies to SimG4Core/CustomPhysics/BuildFile.xml #38874
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38874/31297
|
A new Pull Request was created by @makortel (Matti Kortelainen) for master. It involves the following packages:
@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test for CMSSW_12_5_UBSAN_X |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a67f5b/26490/summary.html The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: |
+1 |
PR description:
The UBSAN IB got broken by #38329 because the PR added dependence on
SimG4Core/Notification
toSimG4Core/CustomPhysics
, but that was not added in theBuildFile.xml
. This PR adds the dependence into theBuildFile.xml
, as well asDataFormats/GeometryVector
that also, in principle at least, should have been added in #38329. Not sure why this wasn't caught by regular IBs, but UBSAN is pickier in having the dependencies declared.PR validation:
None (edited in the web)