Dark Bremsstrahlung backport to 10_6_X #38901

revering · 2022-07-29T21:28:25Z

Backport of implementation of Dark Bremsstrahlung physics process from #38329 to CMSSW_10_6_X for run II MC generation.

CustomPhysics.cc in 10_6_30_patch1 is different from original CMSSW_12_5_X base, but git cms-rebase-topic successfully reapplied the necessary additions for the Dark Brem sim without including other changes. Needed to resolve a merge conflict in CustomPhysics/BuildFile.xml caused by differences in the spacing between <use name> and the ordering of includes between 10_6_X and 12_5_X. Used the 12_5_X spacing and order, should have no effect (as far as I'm aware).

Generated a small test sample with Dark Brem enabled, and the process biases the cross section and produces Dark photons as expected.

Removed unneccesary include of G4GenericBiasingProcess

cmsbuild · 2022-07-29T21:28:43Z

A new Pull Request was created by @revering for CMSSW_10_6_X.

It involves the following packages:

SimG4Core/CustomPhysics (simulation)

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel, @bsunanda, @rovere, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

Backported from Implementation of Dark Bremsstrahlung Custom Process #38329

civanch · 2022-07-30T07:23:57Z

please test

cmsbuild · 2022-07-30T10:39:33Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ccad8b/26540/summary.html
COMMIT: ef78fef
CMSSW: CMSSW_10_6_X_2022-07-24-0000/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38901/26540/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 2 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 3215686
DQMHistoTests: Total failures: 2
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3215350
DQMHistoTests: Total skipped: 334
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
Checked 143 log files, 29 edm output root files, 35 DQM output files
TriggerResults: no differences found

civanch · 2022-07-30T13:35:00Z

+1

cmsbuild · 2022-07-30T13:35:22Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

civanch · 2022-07-30T13:42:25Z

@revering , please add in the beginning of the title of this PR: [10_6_X]

civanch · 2022-07-30T14:00:17Z

SimG4Core/CustomPhysics/src/G4muDarkBremsstrahlungModel.cc

+  for (G4int i = 0; i < nElements; i++) {
+    cross += theAtomNumDensityVector[i] *
+             ComputeCrossSectionPerAtom(
+                 particle, kineticEnergy, (*theElementVector)[i]->GetZ(), (*theElementVector)[i]->GetA(), cut);


@revering , better now than never. (*theElementVector)[i]->GetA() returns molar mass of the atom (see https://geant4.kek.jp/lxr/source/materials/include/G4Element.hh). You need to change to
(*theElementVector)[i]->GetN(). The same patch should be added in 12_4 and 12_5.

civanch · 2022-07-30T14:05:50Z

SimG4Core/CustomPhysics/src/G4muDarkBremsstrahlungModel.cc

+{
+  //Deactivate the process after one dark brem. Needs to be reactivated in the end of event action. If this is in the stepping action instead, more than one brem can occur within each step.
+  G4bool state = false;
+  G4String pname = "muDBrem";


@revering , it is a minor thing but better use G4 mass (avoiding problems in corner cases):

double muMass = dp->GetDefinition()->GetPDGMass(); // this is exact muon mass in internal units (MeV)

civanch · 2022-07-30T14:08:08Z

@revering , I put two comments to the model. Better to implement this just now and forward port in new PRs to 12_4 and 12_5.

qliphy · 2022-07-31T01:14:04Z

backport of #38329 and #38862

qliphy · 2022-08-02T15:58:00Z

@revering Please note there is a comment raised in master PR: #38329 (comment)

qliphy · 2022-08-03T07:28:34Z

#38949 needs to be backported here also. @revering

…le definition instead of hardcoded value and use GetN instead of GetA to get target nucleon number. Implement code-format fix for G4muDarkBremsstrahlungModel Change G4muDarkBremsstrahlungModel to use Geant4 muon mass for muon_mass_mev as well as GeV muon mass.

cmsbuild · 2022-08-03T22:38:15Z

Pull request #38901 was updated. @cmsbuild, @civanch, @mdhildreth can you please check and sign again.

qliphy · 2022-08-04T00:47:37Z

please test

cmsbuild · 2022-08-04T04:28:08Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ccad8b/26633/summary.html
COMMIT: b97a5e7
CMSSW: CMSSW_10_6_X_2022-07-31-0000/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38901/26633/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 3215686
DQMHistoTests: Total failures: 2
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3215350
DQMHistoTests: Total skipped: 334
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
Checked 143 log files, 29 edm output root files, 35 DQM output files
TriggerResults: no differences found

civanch · 2022-08-04T05:21:23Z

+1

cmsbuild · 2022-08-04T05:21:41Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

qliphy · 2022-08-04T09:46:40Z

+1

Michael Revering and others added 3 commits July 29, 2022 14:31

Implemented optional Dark Bremsstrahlung process into custom physics

6901d7a

Removed unneccesary include of G4GenericBiasingProcess

Add missing dependencies

d1d6f70

Update APrimePhysics.h

ef78fef

cmsbuild added this to the CMSSW_10_6_X milestone Jul 29, 2022

cmsbuild added orp-pending pending-signatures simulation-pending tests-pending labels Jul 29, 2022

cmsbuild added tests-started and removed tests-pending labels Jul 30, 2022

cmsbuild added tests-approved and removed tests-started labels Jul 30, 2022

cmsbuild removed simulation-pending pending-signatures labels Jul 30, 2022

cmsbuild added fully-signed simulation-approved labels Jul 30, 2022

civanch reviewed Jul 30, 2022

View reviewed changes

cmsbuild added backport-ok and removed backport-ok labels Jul 31, 2022

Michael Revering added 3 commits August 3, 2022 15:03

Merged DBremSim_10_6_X from repository revering with cms-merge-topic

96f4c32

Removed obsolete PrintInfo() function from G4muDarkBremsstrahlung

397f954

cmsbuild added pending-signatures simulation-pending tests-pending and removed simulation-approved fully-signed tests-approved labels Aug 3, 2022

cmsbuild added tests-started and removed tests-pending labels Aug 4, 2022

cmsbuild added tests-approved and removed tests-started labels Aug 4, 2022

cmsbuild added fully-signed simulation-approved and removed simulation-pending pending-signatures labels Aug 4, 2022

cmsbuild added orp-approved and removed orp-pending labels Aug 4, 2022

cmsbuild merged commit 5629172 into cms-sw:CMSSW_10_6_X Aug 4, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dark Bremsstrahlung backport to 10_6_X #38901

Dark Bremsstrahlung backport to 10_6_X #38901

revering commented Jul 29, 2022 •

edited

Loading

cmsbuild commented Jul 29, 2022 •

edited

Loading

civanch commented Jul 30, 2022

cmsbuild commented Jul 30, 2022

civanch commented Jul 30, 2022

cmsbuild commented Jul 30, 2022

civanch commented Jul 30, 2022

civanch Jul 30, 2022

civanch Jul 30, 2022

civanch commented Jul 30, 2022

qliphy commented Jul 31, 2022 •

edited

Loading

qliphy commented Aug 2, 2022

qliphy commented Aug 3, 2022

cmsbuild commented Aug 3, 2022

qliphy commented Aug 4, 2022

cmsbuild commented Aug 4, 2022

civanch commented Aug 4, 2022

cmsbuild commented Aug 4, 2022

qliphy commented Aug 4, 2022

Dark Bremsstrahlung backport to 10_6_X #38901

Dark Bremsstrahlung backport to 10_6_X #38901

Conversation

revering commented Jul 29, 2022 • edited Loading

cmsbuild commented Jul 29, 2022 • edited Loading

civanch commented Jul 30, 2022

cmsbuild commented Jul 30, 2022

Comparison Summary

civanch commented Jul 30, 2022

cmsbuild commented Jul 30, 2022

civanch commented Jul 30, 2022

civanch Jul 30, 2022

Choose a reason for hiding this comment

civanch Jul 30, 2022

Choose a reason for hiding this comment

civanch commented Jul 30, 2022

qliphy commented Jul 31, 2022 • edited Loading

qliphy commented Aug 2, 2022

qliphy commented Aug 3, 2022

cmsbuild commented Aug 3, 2022

qliphy commented Aug 4, 2022

cmsbuild commented Aug 4, 2022

Comparison Summary

civanch commented Aug 4, 2022

cmsbuild commented Aug 4, 2022

qliphy commented Aug 4, 2022

revering commented Jul 29, 2022 •

edited

Loading

cmsbuild commented Jul 29, 2022 •

edited

Loading

qliphy commented Jul 31, 2022 •

edited

Loading