Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete printInfo from G4muDarkBremsstrahlung #38965

Merged
merged 2 commits into from
Aug 4, 2022

Conversation

revering
Copy link

@revering revering commented Aug 3, 2022

Backport of #38949 to 12_4_X to remove obsolete printInfo and to fix minor issues with getting the material atomic mass and finding the muon mass in G4muDarkBremsstrahlung.
I ran a small sample generation with the new modifications and verified that the correct muon mass is being used and that the atomic numbers found have reasonable values. No issues were observed in the event generation otherwise.

Michael Revering added 2 commits August 3, 2022 17:42
…le definition instead of hardcoded value

and use GetN instead of GetA to get target nucleon number.

Implement code-format fix for G4muDarkBremsstrahlungModel

Change G4muDarkBremsstrahlungModel to use Geant4 muon mass for
muon_mass_mev as well as GeV muon mass.
@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 3, 2022

A new Pull Request was created by @revering for CMSSW_12_4_X.

It involves the following packages:

  • SimG4Core/CustomPhysics (simulation)

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel, @bsunanda, @rovere, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@qliphy
Copy link
Contributor

qliphy commented Aug 4, 2022

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3d8257/26634/summary.html
COMMIT: 75acca3
CMSSW: CMSSW_12_4_X_2022-08-03-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38965/26634/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3676198
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3676168
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@civanch
Copy link
Contributor

civanch commented Aug 4, 2022

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2022

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Aug 4, 2022

+1

@cmsbuild cmsbuild merged commit 7c1f17e into cms-sw:CMSSW_12_4_X Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants