-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove obsolete printInfo from G4muDarkBremsstrahlung #38965
Remove obsolete printInfo from G4muDarkBremsstrahlung #38965
Conversation
…le definition instead of hardcoded value and use GetN instead of GetA to get target nucleon number. Implement code-format fix for G4muDarkBremsstrahlungModel Change G4muDarkBremsstrahlungModel to use Geant4 muon mass for muon_mass_mev as well as GeV muon mass.
A new Pull Request was created by @revering for CMSSW_12_4_X. It involves the following packages:
@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3d8257/26634/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
Backport of #38949 to 12_4_X to remove obsolete printInfo and to fix minor issues with getting the material atomic mass and finding the muon mass in G4muDarkBremsstrahlung.
I ran a small sample generation with the new modifications and verified that the correct muon mass is being used and that the atomic numbers found have reasonable values. No issues were observed in the event generation otherwise.