-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add explicit values to l1t::GlobalObject
enum
#43022
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43022/37194
|
A new Pull Request was created by @missirol (Marino Missiroli) for master. It involves the following packages:
@aloeliger, @epalencia, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-486ff6/35262/summary.html Comparison SummarySummary:
|
+l1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR implements one of the suggestions discussed in #42719 (adding explicit values to enum entries), in order to avoid introducing non-backward-compatible changes to the RAW data tier when modifying the enum
l1t::GlobalObject
(see #42634 (comment) and replies).While editing
GlobalObject.cc
, I noticed a mismatch between this and this. I tried to re-implement the corresponding utilities to avoid such mistakes in the future (these utilities seem to be used in CMSSW only forLogDebug
statements, so they are fairly unconsequential).A related unit test is also added.
Merely technical. No changes expected.
PR validation:
The new unit test passes.
If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:
N/A