Updating the L1TrackObjectNtupleMaker with genJet information and using the SimVertex collection (Master)

[BenjaminRS]

PR description:

This PR resolves the issue reported here: cms-l1t-offline#1097
Namely it fixes the generator level vertex to use the SimVertex collection (from Geant4 SimHits).

PR validation:

This PR passes the following checks:


• scram b
• scram b code-format
• scram b code-checks
• time cmsRun L1Trigger/L1TTrackMatch/test/L1TrackObjectNtupleMaker_cfg.py

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This PR is a port of cms-l1t-offline#1252 to the L1T offline branch

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45422/40872

[cmsbuild]

A new Pull Request was created by @BenjaminRS for master.

It involves the following packages:

• L1Trigger/L1TTrackMatch (l1, upgrade)
• L1Trigger/VertexFinder (l1)

@aloeliger, @cmsbuild, @epalencia, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @mmusich this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[BenjaminRS]

Just to note that this should really be 1 in order to follow what the FW will do.

[epalencia]

Please test

[cmsbuild]

+1

Size: This PR adds an extra 40KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-71f1cd/40327/summary.html
COMMIT: 56bb031
CMSSW: CMSSW_14_1_X_2024-07-09-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45422/40327/install.sh to create a dev area with all the needed externals and cmssw changes.

• DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

• You potentially removed 8 lines from the logs
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3345094
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3345068
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[epalencia]

+l1

[srimanob]

+Upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1