-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[14_1_X] o2oRun_SiStripDCS email warning fix #45978
[14_1_X] o2oRun_SiStripDCS email warning fix #45978
Conversation
A new Pull Request was created by @JanChyczynski for CMSSW_14_1_X. It involves the following packages:
@cmsbuild, @consuegs, @francescobrivio, @perrotta, @saumyaphor4252 can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
cms-bot internal usage |
backport of #45977 |
please test |
+1 Size: This PR adds an extra 16KB to repository Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_14_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @mandrenguyen, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
type bug |
+1 |
PR description:
Backport of #45977
This fixes an error encountered when testing moving
SiStripDetVOff_prompt
O2O from CMSSW_11_0_1 to 14_0_15_patch1. A copy ofSiStripDetVOff_prompt
-SiStripDetVOff_prompt_test
was run for the tests and when it was failing it was trying to send a warning email which caused an exception. The exception's cause is providing abytes
object wherestr
was expected.PR validation:
Tested by running
SiStripDetVOff_prompt_test
on CMSSW_14_0_15_patch1 with local changes (this PR's fix). The O2O was failing when testing providing the certificate for T0 API access (see #45779) - setting TIER0_API_URL=https://cmsweb-preprod.cern.ch/t0wmadatasvc/prod/ (which requires the cert) but not setting X509_USER_CERT. An O2O failure in this test scenario is expected (no cert provided) but it shouldn't cause an error with the email warning and this PR fixes the email error.If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Backport of #45977
FYI @p-masterson @perrotta @PonIlya