Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding subGenJets to NanoGEN #45985

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Conversation

arizzi
Copy link
Contributor

@arizzi arizzi commented Sep 12, 2024

PR description:

This PR adds the SubGenJets to NANOGEN.

PR validation:

Tested on 13_X and produces the expected collections

SubGenJetAK8_pt 7.87129 1.35149
SubGenJetAK8_eta 7.89604 1.2970
SubGenJetAK8_phi 7.89604 1.2970
SubGenJetAK8_mass 7.92079 1.242
nSubGenJetAK8 7.33168 0.925743

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 12, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @arizzi for master.

It involves the following packages:

  • PhysicsTools/NanoAOD (xpog)

@cmsbuild, @ftorrresd, @hqucms can you please review it and eventually sign? Thanks.
@AnnikaStein, @gpetruc this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@hqucms
Copy link
Contributor

hqucms commented Sep 12, 2024

enable nano

@hqucms
Copy link
Contributor

hqucms commented Sep 12, 2024

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3de505/41468/summary.html
COMMIT: 81976c9
CMSSW: CMSSW_14_2_X_2024-09-11-2300/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45985/41468/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3de505/41468/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3de505/41468/git-merge-result

Comparison Summary

Summary:

NANO Comparison Summary

Summary:

  • You potentially added 133 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 21
  • DQMHistoTests: Total histograms compared: 55132
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 55132
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 20 files compared)
  • Checked 102 log files, 58 edm output root files, 21 DQM output files
  • TriggerResults: no differences found

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.001 2.839 2.839 0.000 ( +0.0% ) 3.32 2.61 +26.9% 6.080 6.139
2500.002 2.954 2.954 0.000 ( +0.0% ) 2.94 2.36 +24.8% 6.462 6.464
2500.003 2.900 2.900 0.000 ( +0.0% ) 3.07 2.46 +24.9% 6.422 6.425
2500.011 1.489 1.489 0.000 ( +0.0% ) 5.72 3.84 +49.0% 2.418 2.452
2500.012 1.958 1.958 0.000 ( +0.0% ) 3.14 2.53 +24.3% 2.224 2.643
2500.013 1.809 1.809 0.000 ( +0.0% ) 4.56 3.30 +38.2% 2.243 2.550
2500.021 0.022 0.022 0.000 ( +0.0% ) 1.01 0.69 +46.7% 2.417 2.417
2500.022 0.022 0.022 0.000 ( +0.0% ) 0.95 0.62 +53.6% 2.409 2.411
2500.023 0.022 0.022 0.000 ( +0.0% ) 0.95 0.57 +66.0% 2.289 2.278
2500.024 0.022 0.022 0.000 ( +0.0% ) 0.73 0.44 +64.5% 2.506 2.501
2500.031 0.035 0.035 0.000 ( +0.0% ) 0.91 0.49 +85.4% 2.474 2.472
2500.032 0.036 0.036 0.000 ( +0.0% ) 0.92 0.65 +41.1% 2.442 2.443
2500.033 0.037 0.037 0.000 ( +0.0% ) 0.82 0.48 +71.0% 2.518 2.514
2500.034 0.036 0.036 0.000 ( +0.0% ) 0.83 0.48 +71.7% 2.498 2.488
2500.101 2.660 2.660 0.000 ( +0.0% ) 8.87 5.52 +60.7% 6.365 6.368
2500.111 1.342 1.342 0.000 ( +0.0% ) 19.55 12.60 +55.1% 2.040 2.272
2500.112 1.749 1.749 0.000 ( +0.0% ) 15.12 10.10 +49.7% 2.341 2.341
2500.131 0.747 0.747 0.000 ( +0.0% ) 18.25 11.64 +56.8% 1.536 1.534
2500.201 2.490 2.490 0.000 ( +0.0% ) 7.32 4.90 +49.4% 5.641 5.651
2500.211 1.612 1.612 0.000 ( +0.0% ) 18.06 11.21 +61.1% 2.311 2.309
2500.212 2.055 2.055 0.000 ( +0.0% ) 14.56 8.80 +65.4% 2.396 2.380
2500.221 2.003 2.003 0.000 ( +0.0% ) 7.91 5.48 +44.2% 2.481 2.479
2500.222 3.222 3.222 0.000 ( +0.0% ) 7.75 5.27 +47.1% 2.570 2.566
2500.223 8.902 8.902 0.000 ( +0.0% ) 2.83 1.70 +66.6% 2.484 2.584
2500.224 5.570 5.570 0.000 ( +0.0% ) 1.11 0.73 +51.8% 2.215 2.305
2500.225 5.590 5.590 0.000 ( +0.0% ) 1.02 0.69 +48.3% 2.221 2.302
2500.226 2.988 2.988 0.000 ( +0.0% ) 7.74 5.49 +41.0% 2.570 2.564
2500.227 1.437 1.437 0.000 ( +0.0% ) 11.96 7.69 +55.5% 1.467 1.463
2500.231 1.403 1.403 0.000 ( +0.0% ) 14.33 8.60 +66.6% 2.207 2.218
2500.232 2.260 2.260 0.000 ( +0.0% ) 13.99 8.23 +69.9% 2.296 2.297
2500.233 4.692 4.692 0.000 ( +0.0% ) 4.91 3.37 +45.9% 2.197 2.061
2500.234 3.348 3.348 0.000 ( +0.0% ) 1.53 1.00 +53.7% 2.090 1.724
2500.235 3.359 3.359 0.000 ( +0.0% ) 1.41 0.95 +48.7% 2.118 2.022
2500.236 2.107 2.107 0.000 ( +0.0% ) 13.96 12.13 +15.0% 1.879 2.298
2500.237 1.016 1.016 0.000 ( +0.0% ) 16.24 12.11 +34.1% 1.506 1.280
2500.241 9.405 9.405 0.000 ( +0.0% ) 4.18 2.57 +62.2% 1.999 1.771
2500.242 10.331 10.331 0.000 ( +0.0% ) 0.90 0.52 +70.9% 1.769 1.765
2500.243 2.712 2.712 0.000 ( +0.0% ) 8.67 5.01 +73.1% 1.107 1.102
2500.244 485.976 485.976 0.000 ( +0.0% ) 0.57 0.40 +43.0% 1.713 1.200
2500.245 823.224 823.224 0.000 ( +0.0% ) 0.76 0.47 +61.5% 1.700 1.691
2500.901 1.777 1.749 0.028 ( +1.6% ) 21.70 15.71 +38.1% 1.877 1.871
2500.902 1.626 1.598 0.029 ( +1.8% ) 20.87 17.23 +21.1% 1.805 1.461
2500.911 13.995 13.931 0.064 ( +0.5% ) 3.88 3.06 +27.0% 1.134 1.127
2500.912 0.199 0.438 -0.239 ( -54.5% ) 1.50 1.14 +31.8% 1.006 1.005
2500.913 0.110 0.110 0.000 ( +0.0% ) 1.22 0.84 +45.6% 1.013 1.011

@hqucms
Copy link
Contributor

hqucms commented Sep 12, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 371707a into cms-sw:master Sep 13, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants