VXBS For High Pt #46287

rbhattacharya04 · 2024-10-07T12:57:27Z

This pull request contains

3 elements of the VXBS covariance matrix as 3 different float variables
error on the dxyBS

For Muon. From the discussion we had at the Muon POG, these variables will be enough for implementing VXBS constraint on any kind of muon track.

The error on dxyBS looks similar enough with the error on dxy, which you can see in the attached plot. In the plot the blue curve is error on dxy and red one is error on dxyBS. So if everyone agrees we can drop the error on dxyBs.
dxybsErr_data.pdf

…f CMS

cmsbuild · 2024-10-07T12:57:54Z

cms-bot internal usage

cmsbuild · 2024-10-07T12:59:54Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46287/42109

There are other open Pull requests which might conflict with changes you have proposed:
- File PhysicsTools/NanoAOD/python/muons_cff.py modified in PR(s): [NanoAOD] Add ParticleNet-based Muon ID #46153, [NanoAOD] Add ParticleNet-based Muon ID (Rework of #46153) #46273

cmsbuild · 2024-10-07T13:00:20Z

A new Pull Request was created by @rbhattacharya04 for master.

It involves the following packages:

PhysicsTools/NanoAOD (xpog)

@cmsbuild, @ftorrresd, @hqucms can you please review it and eventually sign? Thanks.
@AnnikaStein, @gpetruc this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

ftorrresd · 2024-10-07T13:06:55Z

enable nano

ftorrresd · 2024-10-07T13:07:28Z

please test

cmsbuild · 2024-10-07T16:18:49Z

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c4ac0a/42022/summary.html
COMMIT: b2f67e6
CMSSW: CMSSW_14_2_X_2024-10-07-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46287/42022/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 2 lines to the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 181 differences found in the comparisons
DQMHistoTests: Total files compared: 44
DQMHistoTests: Total histograms compared: 3331336
DQMHistoTests: Total failures: 1694
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3329622
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
Checked 193 log files, 163 edm output root files, 44 DQM output files
TriggerResults: no differences found

NANO Comparison Summary

Summary:

You potentially removed 647 lines from the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 21
DQMHistoTests: Total histograms compared: 55028
DQMHistoTests: Total failures: 0
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 55028
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 20 files compared)
Checked 102 log files, 58 edm output root files, 21 DQM output files
TriggerResults: no differences found

Nano size comparison Summary:

Sample	kb/ev	ref kb/ev	diff kb/ev	ev/s/thd	ref ev/s/thd	diff rate	mem/thd	ref mem/thd
2500.001	2.961	2.949	0.011 ( +0.4% )	3.07	3.04	+1.0%	6.061	6.061
2500.002	3.072	3.059	0.012 ( +0.4% )	2.73	2.72	+0.4%	6.416	6.402
2500.003	3.013	3.003	0.011 ( +0.4% )	2.86	2.84	+0.9%	6.413	6.385
2500.011	1.549	1.534	0.015 ( +1.0% )	4.73	4.67	+1.3%	2.414	2.420
2500.012	2.050	2.031	0.019 ( +0.9% )	2.88	2.85	+1.3%	2.599	2.608
2500.013	1.890	1.873	0.018 ( +1.0% )	4.07	4.04	+0.9%	2.525	2.518
2500.021	0.022	0.022	0.000 ( +0.0% )	0.93	0.94	-1.2%	2.384	2.385
2500.022	0.022	0.022	0.000 ( +0.0% )	0.89	0.90	-1.6%	2.382	2.371
2500.023	0.022	0.022	0.000 ( +0.0% )	0.88	0.89	-1.5%	2.241	2.245
2500.024	0.022	0.022	0.000 ( +0.0% )	0.66	0.67	-1.3%	2.468	2.471
2500.031	0.035	0.035	0.000 ( +0.0% )	0.83	0.81	+1.8%	2.437	2.446
2500.032	0.036	0.036	0.000 ( +0.0% )	0.84	0.85	-1.5%	2.406	2.420
2500.033	0.037	0.037	0.000 ( +0.0% )	0.75	0.74	+2.2%	2.495	2.489
2500.034	0.036	0.036	0.000 ( +0.0% )	0.77	0.76	+1.7%	2.468	2.465
2500.101	2.746	2.732	0.014 ( +0.5% )	8.55	8.46	+1.1%	6.339	6.956
2500.111	1.406	1.389	0.017 ( +1.3% )	19.29	19.24	+0.3%	2.236	2.233
2500.112	1.824	1.806	0.019 ( +1.0% )	14.52	14.53	-0.1%	2.307	2.310
2500.131	0.747	0.747	0.000 ( +0.0% )	17.55	17.27	+1.6%	1.477	1.502
2500.201	2.568	2.557	0.012 ( +0.5% )	7.39	7.23	+2.2%	5.630	6.233
2500.211	1.722	1.700	0.021 ( +1.3% )	17.26	17.06	+1.2%	2.278	2.279
2500.212	2.116	2.096	0.020 ( +1.0% )	13.94	13.65	+2.1%	2.370	2.363
2500.221	2.017	2.004	0.013 ( +0.6% )	7.61	7.47	+1.8%	2.451	2.448
2500.222	3.294	3.281	0.013 ( +0.4% )	7.45	7.37	+1.1%	2.538	2.535
2500.223	8.981	8.968	0.013 ( +0.1% )	2.62	2.57	+1.8%	2.566	2.566
2500.224	5.828	5.815	0.013 ( +0.2% )	0.60	0.59	+1.2%	2.160	2.384
2500.225	5.846	5.833	0.013 ( +0.2% )	0.58	0.57	+1.9%	2.161	2.383
2500.226	3.056	3.044	0.013 ( +0.4% )	7.29	7.21	+1.1%	2.535	2.532
2500.227	1.437	1.437	0.000 ( +0.0% )	11.40	11.15	+2.2%	1.435	1.436
2500.231	1.424	1.404	0.020 ( +1.4% )	13.71	13.41	+2.2%	2.180	2.180
2500.232	2.321	2.301	0.020 ( +0.9% )	13.23	12.96	+2.1%	2.002	2.272
2500.233	4.768	4.748	0.020 ( +0.4% )	4.13	4.09	+0.8%	2.023	2.280
2500.234	3.539	3.518	0.020 ( +0.6% )	0.76	0.74	+1.5%	2.224	2.074
2500.235	3.551	3.530	0.020 ( +0.6% )	0.75	0.73	+1.6%	2.327	2.095
2500.236	2.166	2.145	0.020 ( +0.9% )	13.73	13.28	+3.4%	2.268	2.274
2500.237	1.016	1.016	0.000 ( +0.0% )	16.68	16.36	+1.9%	1.468	1.467
2500.241	9.404	9.404	0.000 ( +0.0% )	3.55	3.63	-2.1%	1.949	1.949
2500.242	10.331	10.331	0.000 ( +0.0% )	0.85	0.84	+1.3%	1.736	1.732
2500.243	2.712	2.712	0.000 ( +0.0% )	8.17	7.84	+4.3%	1.076	1.078
2500.244	485.976	485.976	0.000 ( +0.0% )	0.54	0.52	+3.4%	1.684	1.670
2500.245	823.202	823.202	0.000 ( +0.0% )	0.72	0.70	+2.5%	1.659	1.678
2500.901	1.777	1.777	0.000 ( +0.0% )	20.36	19.06	+6.8%	1.840	1.842
2500.902	1.626	1.626	0.000 ( +0.0% )	21.18	19.31	+9.7%	1.771	1.772
2500.911	13.995	13.995	0.000 ( +0.0% )	2.18	3.19	-31.7%	1.095	1.097
2500.912	0.150	0.240	-0.090 ( -37.5% )	1.19	1.45	-17.5%	0.975	0.975
2500.913	0.110	0.110	0.000 ( +0.0% )	1.09	1.09	-0.6%	0.980	0.974

instead of muonBestTrack, which was a mistake

rbhattacharya04 · 2024-10-11T14:19:55Z

There was an error. The covariance matrix should have been read form tunePMuonBestTrack. At the first commit, it was read from muonBestTrack. At this commit now, this error is fixed, now it is read from tunePMuonBestTrack.

rbhattacharya04 · 2024-10-25T09:12:58Z

There was a suggestion just yesterday to add the tuneP_charge in the NanoAODs. So, I have done another commit just adding the tuneP_charge.

cmsbuild · 2024-10-25T09:16:06Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46287/42365

There are other open Pull requests which might conflict with changes you have proposed:
- File PhysicsTools/NanoAOD/python/muons_cff.py modified in PR(s): [NanoAOD] Add ParticleNet-based Muon ID #46153, [NanoAOD] Add ParticleNet-based Muon ID (Rework of #46153) #46273
- File PhysicsTools/NanoAOD/python/nanoDQM_cfi.py modified in PR(s): [NanoAOD] Add ParticleNet-based Muon ID (Rework of #46153) #46273

cmsbuild · 2024-10-25T09:16:25Z

Pull request #46287 was updated. @cmsbuild, @ftorrresd, @hqucms can you please check and sign again.

hqucms · 2024-10-25T09:46:28Z

please test

ftorrresd · 2024-10-28T14:56:37Z

please abort

ftorrresd · 2024-10-28T14:57:07Z

please test

cmsbuild · 2024-10-28T19:08:36Z

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c4ac0a/42426/summary.html
COMMIT: bb867d1
CMSSW: CMSSW_14_2_X_2024-10-28-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46287/42426/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 2 lines from the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 176 differences found in the comparisons
DQMHistoTests: Total files compared: 46
DQMHistoTests: Total histograms compared: 3569177
DQMHistoTests: Total failures: 417
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3568740
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 103.54299999999995 KiB( 45 files compared)
DQMHistoSizes: changed ( 11634.0,... ): 7.975 KiB Physics/NanoAODDQM
DQMHistoSizes: changed ( 13234.0,... ): 5.302 KiB Physics/NanoAODDQM
Checked 201 log files, 171 edm output root files, 46 DQM output files
TriggerResults: no differences found

NANO Comparison Summary

Summary:

You potentially added 775 lines to the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 21
DQMHistoTests: Total histograms compared: 55168
DQMHistoTests: Total failures: 0
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 55168
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 76.98899999999998 KiB( 20 files compared)
DQMHistoSizes: changed ( 2500.001,... ): 7.975 KiB Physics/NanoAODDQM
DQMHistoSizes: changed ( 2500.011,... ): 5.302 KiB Physics/NanoAODDQM
Checked 102 log files, 58 edm output root files, 21 DQM output files
TriggerResults: no differences found

Nano size comparison Summary:

Sample	kb/ev	ref kb/ev	diff kb/ev	ev/s/thd	ref ev/s/thd	diff rate	mem/thd	ref mem/thd
2500.001	3.012	3.000	0.012 ( +0.4% )	2.99	2.98	+0.5%	2.284	2.365
2500.002	3.124	3.110	0.014 ( +0.5% )	2.67	2.66	+0.3%	2.292	2.798
2500.003	3.065	3.054	0.012 ( +0.4% )	2.78	2.78	-0.0%	2.319	2.787
2500.011	1.591	1.575	0.016 ( +1.0% )	4.64	4.66	-0.5%	2.030	2.462
2500.012	2.113	2.093	0.019 ( +0.9% )	2.78	2.81	-1.4%	2.034	2.663
2500.013	1.936	1.917	0.019 ( +1.0% )	3.96	4.01	-1.2%	1.930	2.566
2500.021	0.022	0.022	0.000 ( +0.0% )	0.94	0.94	-0.6%	2.377	2.424
2500.022	0.022	0.022	0.000 ( +0.0% )	0.91	0.90	+0.5%	2.378	2.419
2500.023	0.022	0.022	0.000 ( +0.0% )	0.89	0.89	-0.0%	2.281	2.291
2500.024	0.022	0.022	0.000 ( +0.0% )	0.67	0.68	-1.0%	2.481	2.516
2500.031	0.035	0.035	0.000 ( +0.0% )	0.84	0.83	+0.4%	2.289	2.499
2500.032	0.036	0.036	0.000 ( +0.0% )	0.84	0.84	+0.8%	2.249	2.446
2500.033	0.037	0.037	0.000 ( +0.0% )	0.78	0.77	+1.7%	2.327	2.539
2500.034	0.036	0.036	0.000 ( +0.0% )	0.79	0.77	+2.8%	2.320	2.515
2500.101	2.766	2.753	0.013 ( +0.5% )	7.68	7.58	+1.3%	2.013	2.603
2500.111	1.419	1.399	0.020 ( +1.4% )	16.95	17.60	-3.7%	2.291	2.305
2500.112	1.838	1.818	0.020 ( +1.1% )	14.16	14.00	+1.1%	2.390	2.375
2500.131	0.747	0.747	0.000 ( +0.0% )	18.40	18.21	+1.1%	1.518	1.419
2500.201	2.595	2.582	0.013 ( +0.5% )	6.44	6.11	+5.5%	2.161	2.114
2500.211	1.757	1.736	0.021 ( +1.2% )	15.43	15.14	+1.9%	2.369	2.377
2500.212	2.152	2.131	0.022 ( +1.0% )	12.77	12.63	+1.1%	2.450	2.454
2500.221	2.016	2.003	0.013 ( +0.6% )	6.70	6.66	+0.5%	2.085	2.033
2500.222	3.392	3.378	0.014 ( +0.4% )	6.30	6.20	+1.6%	2.172	2.117
2500.223	9.357	9.343	0.014 ( +0.1% )	1.81	1.81	-0.4%	2.242	2.194
2500.224	6.040	6.026	0.014 ( +0.2% )	0.59	0.59	+0.5%	2.193	2.068
2500.225	6.072	6.058	0.014 ( +0.2% )	0.57	0.56	+0.6%	2.261	2.260
2500.226	3.086	3.072	0.014 ( +0.4% )	6.43	6.53	-1.6%	2.168	2.168
2500.227	1.437	1.437	0.000 ( +0.0% )	11.94	11.74	+1.7%	1.446	1.445
2500.231	1.429	1.408	0.020 ( +1.4% )	12.61	12.56	+0.5%	2.271	2.265
2500.232	2.412	2.390	0.022 ( +0.9% )	11.70	11.65	+0.4%	2.364	2.366
2500.233	4.904	4.882	0.022 ( +0.4% )	2.77	2.76	+0.4%	2.436	2.418
2500.234	3.670	3.648	0.022 ( +0.6% )	0.76	0.76	-0.3%	2.164	2.160
2500.235	3.689	3.667	0.022 ( +0.6% )	0.72	0.72	-0.2%	2.207	2.204
2500.236	2.202	2.180	0.022 ( +1.0% )	12.52	12.06	+3.9%	2.363	2.364
2500.237	1.016	1.016	0.000 ( +0.0% )	17.34	17.20	+0.8%	1.445	1.424
2500.241	9.404	9.404	0.000 ( +0.0% )	3.80	3.63	+4.9%	1.932	1.932
2500.242	10.331	10.331	0.000 ( +0.0% )	0.91	0.88	+3.9%	1.230	1.517
2500.243	2.712	2.712	0.000 ( +0.0% )	8.46	8.41	+0.7%	1.086	0.897
2500.244	485.976	485.976	0.000 ( +0.0% )	0.57	0.56	+1.7%	1.702	1.681
2500.245	823.202	823.202	0.000 ( +0.0% )	0.75	0.74	+1.4%	1.674	1.686
2500.901	1.777	1.777	0.000 ( +0.0% )	21.80	21.74	+0.3%	1.431	1.430
2500.902	1.626	1.626	0.000 ( +0.0% )	22.08	22.36	-1.2%	1.334	1.334
2500.911	13.995	13.995	0.000 ( +0.0% )	3.83	3.02	+26.5%	1.102	1.105
2500.912	0.199	0.729	-0.530 ( -72.7% )	1.07	1.61	-33.7%	0.989	0.979
2500.913	0.110	0.110	0.000 ( +0.0% )	1.19	1.12	+6.5%	0.989	0.988

ftorrresd · 2024-10-28T19:44:11Z

+1

cmsbuild · 2024-10-28T19:44:38Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @mandrenguyen, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

mandrenguyen · 2024-10-29T06:04:36Z

+1

jo100sun and others added 6 commits October 7, 2024 11:55

Etawise GEM TnP

27df8e4

Make Era dependent ZDV geometry - backport cms-sw#45511

bf40e40

Backport from cms-sw#46033 new definition of 2024 Geometry Scenario o…

aff2d41

…f CMS

VXBS Covariance matrix

a2d6773

Added the dxyBsErr

bf6c8d2

Just cleanup

b2f67e6

cmsbuild added this to the CMSSW_14_2_X milestone Oct 7, 2024

cmsbuild added pending-signatures tests-pending orp-pending code-checks-pending xpog-pending labels Oct 7, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 7, 2024

cmsbuild added tests-started and removed tests-pending labels Oct 7, 2024

cmsbuild added tests-approved and removed tests-started labels Oct 7, 2024

Error fixes, the covaraince matrix is now taken from tunePMuonBestTrack,

ba405f1

instead of muonBestTrack, which was a mistake

cmsbuild added tests-pending code-checks-pending and removed tests-approved code-checks-approved labels Oct 11, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 25, 2024

cmsbuild added tests-started and removed tests-pending labels Oct 25, 2024

cmsbuild mentioned this pull request Oct 28, 2024

[NanoAOD] Add ParticleNet-based Muon ID (Rework of #46153) #46273

Merged

cmsbuild added tests-pending and removed tests-started labels Oct 28, 2024

cmsbuild added tests-started and removed tests-pending labels Oct 28, 2024

cmsbuild added tests-approved and removed tests-started labels Oct 28, 2024

cmsbuild added fully-signed xpog-approved and removed pending-signatures xpog-pending labels Oct 28, 2024

cmsbuild added orp-approved and removed orp-pending labels Oct 29, 2024

cmsbuild merged commit 5754132 into cms-sw:master Oct 29, 2024
13 checks passed

This was referenced Oct 30, 2024

[DEVEL] Fix symlinks for PATH and PYTHONPATH cms-sw/cmsdist#9487

Merged

Rivet 4.0.1 and YODA 2.0.1 cms-sw/cmsdist#9481

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

VXBS For High Pt #46287

VXBS For High Pt #46287

rbhattacharya04 commented Oct 7, 2024

cmsbuild commented Oct 7, 2024 •

edited

Loading

cmsbuild commented Oct 7, 2024

cmsbuild commented Oct 7, 2024

ftorrresd commented Oct 7, 2024

ftorrresd commented Oct 7, 2024

cmsbuild commented Oct 7, 2024

rbhattacharya04 commented Oct 11, 2024

rbhattacharya04 commented Oct 25, 2024

cmsbuild commented Oct 25, 2024

cmsbuild commented Oct 25, 2024

hqucms commented Oct 25, 2024

ftorrresd commented Oct 28, 2024

ftorrresd commented Oct 28, 2024

cmsbuild commented Oct 28, 2024

ftorrresd commented Oct 28, 2024

cmsbuild commented Oct 28, 2024

mandrenguyen commented Oct 29, 2024

VXBS For High Pt #46287

VXBS For High Pt #46287

Conversation

rbhattacharya04 commented Oct 7, 2024

cmsbuild commented Oct 7, 2024 • edited Loading

cmsbuild commented Oct 7, 2024

cmsbuild commented Oct 7, 2024

ftorrresd commented Oct 7, 2024

ftorrresd commented Oct 7, 2024

cmsbuild commented Oct 7, 2024

Comparison Summary

NANO Comparison Summary

rbhattacharya04 commented Oct 11, 2024

rbhattacharya04 commented Oct 25, 2024

cmsbuild commented Oct 25, 2024

cmsbuild commented Oct 25, 2024

hqucms commented Oct 25, 2024

ftorrresd commented Oct 28, 2024

ftorrresd commented Oct 28, 2024

cmsbuild commented Oct 28, 2024

Comparison Summary

NANO Comparison Summary

ftorrresd commented Oct 28, 2024

cmsbuild commented Oct 28, 2024

mandrenguyen commented Oct 29, 2024

cmsbuild commented Oct 7, 2024 •

edited

Loading