Phase2-hgx360I Change names from 2026 to Run4 in several scripts of Geometry (CaloTopology|ForwardCommonData|GEMGeometry|MTDCommonData|MuonNumbering|TrackerCommonData|TrackerGeometryBuilder)

[bsunanda]

PR description:

Change names from 2026 to Run4 in several scripts of Geometry (CaloTopology|ForwardCommonData|GEMGeometry|MTDCommonData|MuonNumbering|TrackerCommonData|TrackerGeometryBuilder)

PR validation:

Tested the modified scripts

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Nothing special

[cmsbuild]

cms-bot internal usage

[bsunanda]

@cmsbuild Please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46648/42565

[cmsbuild]

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

• Geometry/CaloTopology (geometry)
• Geometry/ForwardCommonData (geometry)
• Geometry/GEMGeometry (upgrade, geometry)
• Geometry/MTDCommonData (upgrade, geometry)
• Geometry/MuonCommonData (geometry)
• Geometry/MuonNumbering (geometry)
• Geometry/TrackerCommonData (geometry)
• Geometry/TrackerGeometryBuilder (geometry)

@Dr15Jones, @Moanwar, @bsunanda, @civanch, @kpedro88, @makortel, @mdhildreth, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@ReyerBand, @VinInn, @VourMa, @fabiocos, @ghugo83, @giovanni-mocellin, @jshlee, @martinamalberti, @mmusich, @mtosi, @ptcox, @slomeo, @thomreis, @vargasa, @venturia, @wang0jin, @watson-ij this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1

Size: This PR adds an extra 28KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7e7eca/42711/summary.html
COMMIT: 8ca8d11
CMSSW: CMSSW_14_2_X_2024-11-10-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46648/42711/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 1 lines to the logs
• Reco comparison results: 7 differences found in the comparisons
• DQMHistoTests: Total files compared: 46
• DQMHistoTests: Total histograms compared: 3343588
• DQMHistoTests: Total failures: 512
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3343056
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
• Checked 202 log files, 172 edm output root files, 46 DQM output files
• TriggerResults: no differences found

[bsunanda]

+geometry

[srimanob]

Hi @bsunanda
Thanks for the PR. Do you have PRs to come on updating name, on configuration and filenames? So I can recheck again after this PR is merged. For geometry XMLs and folders under Geometry, I will not touch.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46648/42584

[cmsbuild]

Pull request #46648 was updated. @Dr15Jones, @Moanwar, @bsunanda, @civanch, @cmsbuild, @kpedro88, @makortel, @mdhildreth, @srimanob, @subirsarkar can you please check and sign again.

[bsunanda]

Hi Phat, I plan to update directory names from 2026 to 2030 for all phase 2 geometries. This will modify all Run4 scenarios. I shall do this once this batch of scenario names are completed. I believe Geometr/SimG4Core/SimG4CMS is now all done. I just added one more PR

…

________________________________ From: Phat Srimanobhas ***@***.***> Sent: 11 November 2024 20:14 To: cms-sw/cmssw ***@***.***> Cc: Sunanda Banerjee ***@***.***>; Mention ***@***.***> Subject: Re: [cms-sw/cmssw] Phase2-hgx360I Change names from 2026 to Run4 in several scripts of Geometry (CaloTopology|ForwardCommonData|GEMGeometry|MTDCommonData|MuonNumbering|TrackerCommonData|TrackerGeometryBuilder) (PR #46648) Hi @bsunanda<https://github.com/bsunanda> Thanks for the PR. Do you have PRs to come on updating name, on configuration and filenames? So I can recheck again after this PR is merged. For geometry XMLs and folders under Geometry, I will not touch. — Reply to this email directly, view it on GitHub<#46648 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABGMZOS3CUMI55LRCIB7UUL2AC7GFAVCNFSM6AAAAABRRLI2Q6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRYGM2DMNZUGU>. You are receiving this because you were mentioned.Message ID: ***@***.***>

[bsunanda]

@cmsbuild Please test

[civanch]

@bsunanda , @srimanob , do I understand correctly that the schema will be following: most python scripts will have "Run4" inside instead of year. Some geometry directories will migrate to 2026 -> 2030. In past, having files corresponding to years was useful but knowing in advance what year will run4 start/changed/ likely impossible. Should we still use year or we can everywhere migrate to "Run4"?

[bsunanda]

I believe you have to start with Run4. If geometry changes from year to year, which happened during Run2 and Run3, you may have to give the year name instead of Run4 for the declaration of a scenario. Only time will tell

…

________________________________ From: Vladimir Ivantchenko ***@***.***> Sent: 11 November 2024 22:07 To: cms-sw/cmssw ***@***.***> Cc: Sunanda Banerjee ***@***.***>; Mention ***@***.***> Subject: Re: [cms-sw/cmssw] Phase2-hgx360I Change names from 2026 to Run4 in several scripts of Geometry (CaloTopology|ForwardCommonData|GEMGeometry|MTDCommonData|MuonNumbering|TrackerCommonData|TrackerGeometryBuilder) (PR #46648) @bsunanda<https://github.com/bsunanda> , @srimanob<https://github.com/srimanob> , do I understand correctly that the schema will be following: most python scripts will have "Run4" inside instead of year. Some geometry directories will migrate to 2026 -> 2030. In past, having files corresponding to years was useful but knowing in advance what year will run4 start/changed/ likely impossible. Should we still use year or we can everywhere migrate to "Run4"? — Reply to this email directly, view it on GitHub<#46648 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABGMZOVHHIBOF7WXWNYFKI32ADMOBAVCNFSM6AAAAABRRLI2Q6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRYGU4TEOBXGQ>. You are receiving this because you were mentioned.Message ID: ***@***.***>

[srimanob]

I would propose we stay with Run4 as much as possible, and keep 2030 for specific things for that year, that we may need in near future.

[cmsbuild]

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7e7eca/42734/summary.html
COMMIT: 4592189
CMSSW: CMSSW_14_2_X_2024-11-11-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46648/42734/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 3 lines to the logs
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 46
• DQMHistoTests: Total histograms compared: 3343588
• DQMHistoTests: Total failures: 422
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3343146
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
• Checked 202 log files, 172 edm output root files, 46 DQM output files
• TriggerResults: no differences found

[bsunanda]

+geometry

[bsunanda]

@Moanwar, @srimanob, @subirsarkar Please approve this PR

[Moanwar]

+Upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @mandrenguyen, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1