use faster variant of OmniClusterRef and RefCoreWithIndex initialization

[slava77]

this was motivated by inspection of SiStripRecHitConverterAlgorithm in the HLT context (runs without matching; expected to be used in HLT in combination with mkFit)

The overhead of making the OmniClusterRef via edmNew::DetSet::makeRefTo appeared too costly due to mostly trivial calls cluttered by unnecessary out-of-line calls that prevented the compiler optimization.

• In the setup with mkFit in HLT the speedup in SiStripRecHitConverter::produce is around 6% (relative);
• the change in the offline setup is mostly negligible due to running rphi-stereo matching which dominates SiStripRecHitConverter

No physics changes are expected.

There are probably benefits from using a similar OmniClusterRef constructor in other places, like SiPixelRecHitFromSoAAlpaka, but it's not a significant contributor to the total cost.

@cms-sw/tracking-pog-l2 @cms-sw/trk-dpg-l2

[cmsbuild]

cms-bot internal usage

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47174/43414

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47174/43414/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47174/43414/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47174/43415

[cmsbuild]

A new Pull Request was created by @slava77 for master.

It involves the following packages:

• DataFormats/Common (core)
• DataFormats/TrackerRecHit2D (reconstruction)
• RecoLocalTracker/SiStripRecHitConverter (reconstruction)

@Dr15Jones, @cmsbuild, @jfernan2, @makortel, @mandrenguyen, @smuzaffar can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @VinInn, @VourMa, @alesaggio, @echabert, @felicepantaleo, @gbenelli, @gpetruc, @jlidrych, @makortel, @missirol, @mmusich, @mtosi, @robervalwalsh, @rovere, @threus, @wddgit, @yduhm this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[slava77]

@cmsbuild please test

[cmsbuild]

+1

Size: This PR adds an extra 40KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-329b4c/43934/summary.html
COMMIT: 6689fe4
CMSSW: CMSSW_15_0_X_2025-01-23-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47174/43934/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 2 lines from the logs
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3932183
• DQMHistoTests: Total failures: 68
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3932095
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 218 log files, 189 edm output root files, 50 DQM output files
• TriggerResults: no differences found