Skip to content
This repository has been archived by the owner on Sep 27, 2019. It is now read-only.

Fix travis build to actually use gcc5 #1330

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tcm-marcel
Copy link
Contributor

Travis vehemently ignores our environmental variables for gcc5, but setting it in front of the cmake command works.

@pmenon gave this hint before, but it was forgotten in #1311.

pervazea
pervazea previously approved these changes Apr 25, 2018
@pmenon
Copy link
Member

pmenon commented Apr 25, 2018

@tcm-marcel For consistency, you should set CC=gcc-5, too.

Also, I wonder if you can export the CXX and CC variables before invoking the build? Then the cmake invocation should remain the same and, hopefully, make the environment setup clear.

@coveralls
Copy link

coveralls commented Apr 25, 2018

Coverage Status

Coverage decreased (-77.9%) to 0.0% when pulling 29ba99e on tcm-marcel:build/deprecate-gcc48 into bf7ff62 on cmu-db:master.

@tcm-marcel
Copy link
Contributor Author

@pmenon I just wanted to show you that this happens already when specifying it in the travis file.
But then I saw that in fact it does happen, but the variables get overridden a few lines later.

grafik

We can again override it just before the invocation.

@pmenon
Copy link
Member

pmenon commented Apr 25, 2018

@tcm-marcel Huh, then it looks like the stuff in env is getting overridden. Does it make sense to move everything currently in env into before_script as export's?

I just found this as an example.

@tcm-marcel tcm-marcel force-pushed the build/deprecate-gcc48 branch 2 times, most recently from 73befdf to d4f4e05 Compare April 25, 2018 18:52
@tcm-marcel
Copy link
Contributor Author

The tests fail because of an incompatibility between the pre-compiled tensorflow version and protobuf, which is already discussed on the mailing list. I will leave this open, until we have a solution/workaround for this.

@tcm-marcel tcm-marcel force-pushed the build/deprecate-gcc48 branch from d4f4e05 to 29ba99e Compare June 20, 2018 15:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants