[15721] Peloton Self-Driving Infrastructure #1346

ChTimTsubasa · 2018-05-05T03:58:52Z

This PR is working toward an infrastructure for self-driving components on Peloton.

In this checkpoint, we presented:

A brand new framework for stats collections.
2, Based on the new framework we collected
1. query metrics measuring latency for queries.
2. table metrics measuring operations count on a specific table, memory usage and memory allocation for both inline data and varlen data
3. index metrics measuring operations count on a specific index, estimated memory usage and memory allocation stats.

To do:
Update metrics on catalog

implement memory metric header 2 memory metric hook up

…nto 721-Proj3

This reverts commit 754901b.

AbstractMetric just exists for GetInfo()/Reset(). PointMetric is an abstraction for counter-like metrics which get incremented/decremented at a specific point of execution. IntervalMetric is an abstraction for timer-based metrics whose measurements occur over some duration of execution.

…nto 721-Proj3 Conflicts: src/include/statistics/point_metric.h

ChTimTsubasa · 2018-05-12T05:24:53Z

This is not going to add much overhead to the engine as the collector would not be blocked. Actually, the blocking thing is the background aggregating thread as it is CAS on the safe_ flag.

We would like the test the overhead with some TPCC testbench but it seems that the master branch is running slow. We would definitely run TPCC if we get fast enough later, and we claim it's not going to be hard (just change the stats_mode would switch the collection from on/off).

ChTimTsubasa · 2018-05-12T05:26:37Z

Test cases for the framework are added in stats_framework_test.cpp

…nto 721-Proj3

…nto 721-Proj3 # Conflicts: # src/catalog/index_metrics_catalog.cpp # src/include/catalog/index_metrics_catalog.h # src/statistics/index_metric.cpp

…nto 721-Proj3

sivaprasadsudhir · 2018-05-13T00:18:27Z

src/catalog/catalog.cpp

@@ -33,6 +32,7 @@
 #include "function/timestamp_functions.h"
 #include "index/index_factory.h"
 #include "settings/settings_manager.h"
+#include "storage/database.h"


In line 198 of this file, the flag should be brain_data_collection. Probably the reason why query_logger_test is failing.

Change it. Still failing the test. The log is

174: 2018-05-13 10:48:16 [test/sql/testing_sql_util.cpp:60:ExecuteSQLQuery] INFO - Query: SELECT query_string, fingerprint FROM peloton.pg_catalog.pg_query_history;
174: 2018-05-13 10:48:16 [src/codegen/operator/table_scan_translator.cpp:40:TableScanTranslator] DEBUG - Constructing TableScanTranslator ...
174: 2018-05-13 10:48:16 [test/sql/testing_sql_util.cpp:95:ExecuteSQLQuery] INFO - Statement executed. Result: SUCCESS
174: 2018-05-13 10:48:21 [test/sql/testing_sql_util.cpp:60:ExecuteSQLQuery] INFO - Query: SELECT query_string, fingerprint FROM peloton.pg_catalog.pg_query_history;
174: 2018-05-13 10:48:21 [test/sql/testing_sql_util.cpp:95:ExecuteSQLQuery] INFO - Statement executed. Result: SUCCESS
174: 2018-05-13 10:48:26 [test/sql/testing_sql_util.cpp:60:ExecuteSQLQuery] INFO - Query: SELECT query_string, fingerprint FROM peloton.pg_catalog.pg_query_history;
174: 2018-05-13 10:48:26 [test/sql/testing_sql_util.cpp:95:ExecuteSQLQuery] INFO - Statement executed. Result: SUCCESS
174: 2018-05-13 10:48:31 [test/sql/testing_sql_util.cpp:60:ExecuteSQLQuery] INFO - Query: SELECT query_string, fingerprint FROM peloton.pg_catalog.pg_query_history;
174: 2018-05-13 10:48:31 [test/sql/testing_sql_util.cpp:95:ExecuteSQLQuery] INFO - Statement executed. Result: SUCCESS
174: 2018-05-13 10:48:36 [test/sql/testing_sql_util.cpp:60:ExecuteSQLQuery] INFO - Query: SELECT query_string, fingerprint FROM peloton.pg_catalog.pg_query_history;
174: 2018-05-13 10:48:36 [test/sql/testing_sql_util.cpp:95:ExecuteSQLQuery] INFO - Statement executed. Result: SUCCESS
174: 2018-05-13 10:48:41 [test/sql/testing_sql_util.cpp:60:ExecuteSQLQuery] INFO - Query: SELECT query_string, fingerprint FROM peloton.pg_catalog.pg_query_history;
174: 2018-05-13 10:48:41 [test/sql/testing_sql_util.cpp:95:ExecuteSQLQuery] INFO - Statement executed. Result: SUCCESS
174: /home/tianyi/Documents/project/peloton/test/sql/testing_sql_util.cpp:274: Failure
174: Value of: actual_result.size()
174: Actual: 10
174: Expected: ref_result.size()
174: Which is: 11
174: /home/tianyi/Documents/project/peloton/test/sql/testing_sql_util.cpp:282: Failure
174: Value of: actual_result
174: Actual: { "CREATE TABLE test(a INT);|015a5c39f1d456672ab662e8bf9d13598d5d87f697", "SELECT query_string, fingerprint FROM peloton.pg_catalog.pg_query_history;|01851b97a4b7d3bc7fefc53d3b920878c08c4cc914", "INSERT INTO test VALUES (1);|01494aa495a99247b2fe92808c6ae2df065e2ec101", "SELECT query_string, fingerprint FROM peloton.pg_catalog.pg_query_history;|01851b97a4b7d3bc7fefc53d3b920878c08c4cc914", "INSERT INTO test VALUES (2);|01494aa495a99247b2fe92808c6ae2df065e2ec101", "SELECT query_string, fingerprint FROM peloton.pg_catalog.pg_query_history;|01851b97a4b7d3bc7fefc53d3b920878c08c4cc914", "BEGIN;|011e0b3628080f24ada46945aaaa12f4ae69ed0a3b", "SELECT query_string, fingerprint FROM peloton.pg_catalog.pg_query_history;|01851b97a4b7d3bc7fefc53d3b920878c08c4cc914", "INSERT INTO test VALUES (1);|01494aa495a99247b2fe92808c6ae2df065e2ec101", "COMMIT;|01cf0fba0f1cfd731e80292bd9c5e92abbec9056d1" }
174: Expected: ref_result
174: Which is: { "CREATE TABLE test(a INT);|015a5c39f1d456672ab662e8bf9d13598d5d87f697", "SELECT query_string, fingerprint FROM peloton.pg_catalog.pg_query_history;|01851b97a4b7d3bc7fefc53d3b920878c08c4cc914", "INSERT INTO test VALUES (1);|01494aa495a99247b2fe92808c6ae2df065e2ec101", "SELECT query_string, fingerprint FROM peloton.pg_catalog.pg_query_history;|01851b97a4b7d3bc7fefc53d3b920878c08c4cc914", "INSERT INTO test VALUES (2);|01494aa495a99247b2fe92808c6ae2df065e2ec101", "SELECT query_string, fingerprint FROM peloton.pg_catalog.pg_query_history;|01851b97a4b7d3bc7fefc53d3b920878c08c4cc914", "BEGIN;|011e0b3628080f24ada46945aaaa12f4ae69ed0a3b", "SELECT query_string, fingerprint FROM peloton.pg_catalog.pg_query_history;|01851b97a4b7d3bc7fefc53d3b920878c08c4cc914", "INSERT INTO test VALUES (1);|01494aa495a99247b2fe92808c6ae2df065e2ec101", "SELECT query_string, fingerprint FROM peloton.pg_catalog.pg_query_history;|01851b97a4b7d3bc7fefc53d3b920878c08c4cc914", "COMMIT;|01cf0fba0f1cfd731e80292bd9c5e92abbec9056d1" }
174: 2018-05-13 10:48:46 [test/sql/testing_sql_util.cpp:60:ExecuteSQLQuery] INFO - Query: SELECT query_string, fingerprint FROM peloton.pg_catalog.pg_query_history;
174: 2018-05-13 10:48:46 [test/sql/testing_sql_util.cpp:95:ExecuteSQLQuery] INFO - Statement executed. Result: SUCCESS
174: /home/tianyi/Documents/project/peloton/test/sql/testing_sql_util.cpp:274: Failure
174: Value of: actual_result.size()
174: Actual: 12
174: Expected: ref_result.size()
174: Which is: 13
174: /home/tianyi/Documents/project/peloton/test/sql/testing_sql_util.cpp:282: Failure
174: Value of: actual_result
174: Actual: { "CREATE TABLE test(a INT);|015a5c39f1d456672ab662e8bf9d13598d5d87f697", "SELECT query_string, fingerprint FROM peloton.pg_catalog.pg_query_history;|01851b97a4b7d3bc7fefc53d3b920878c08c4cc914", "INSERT INTO test VALUES (1);|01494aa495a99247b2fe92808c6ae2df065e2ec101", "SELECT query_string, fingerprint FROM peloton.pg_catalog.pg_query_history;|01851b97a4b7d3bc7fefc53d3b920878c08c4cc914", "INSERT INTO test VALUES (2);|01494aa495a99247b2fe92808c6ae2df065e2ec101", "SELECT query_string, fingerprint FROM peloton.pg_catalog.pg_query_history;|01851b97a4b7d3bc7fefc53d3b920878c08c4cc914", "BEGIN;|011e0b3628080f24ada46945aaaa12f4ae69ed0a3b", "SELECT query_string, fingerprint FROM peloton.pg_catalog.pg_query_history;|01851b97a4b7d3bc7fefc53d3b920878c08c4cc914", "INSERT INTO test VALUES (1);|01494aa495a99247b2fe92808c6ae2df065e2ec101", "COMMIT;|01cf0fba0f1cfd731e80292bd9c5e92abbec9056d1", "SELECT query_string, fingerprint FROM peloton.pg_catalog.pg_query_history;|01851b97a4b7d3bc7fefc53d3b920878c08c4cc914", "SELECT query_string, fingerprint FROM peloton.pg_catalog.pg_query_history;|01851b97a4b7d3bc7fefc53d3b920878c08c4cc914" }
174: Expected: ref_result
174: Which is: { "CREATE TABLE test(a INT);|015a5c39f1d456672ab662e8bf9d13598d5d87f697", "SELECT query_string, fingerprint FROM peloton.pg_catalog.pg_query_history;|01851b97a4b7d3bc7fefc53d3b920878c08c4cc914", "INSERT INTO test VALUES (1);|01494aa495a99247b2fe92808c6ae2df065e2ec101", "SELECT query_string, fingerprint FROM peloton.pg_catalog.pg_query_history;|01851b97a4b7d3bc7fefc53d3b920878c08c4cc914", "INSERT INTO test VALUES (2);|01494aa495a99247b2fe92808c6ae2df065e2ec101", "SELECT query_string, fingerprint FROM peloton.pg_catalog.pg_query_history;|01851b97a4b7d3bc7fefc53d3b920878c08c4cc914", "BEGIN;|011e0b3628080f24ada46945aaaa12f4ae69ed0a3b", "SELECT query_string, fingerprint FROM peloton.pg_catalog.pg_query_history;|01851b97a4b7d3bc7fefc53d3b920878c08c4cc914", "INSERT INTO test VALUES (1);|01494aa495a99247b2fe92808c6ae2df065e2ec101", "SELECT query_string, fingerprint FROM peloton.pg_catalog.pg_query_history;|01851b97a4b7d3bc7fefc53d3b920878c08c4cc914", "COMMIT;|01cf0fba0f1cfd731e80292bd9c5e92abbec9056d1", "SELECT query_string, fingerprint FROM peloton.pg_catalog.pg_query_history;|01851b97a4b7d3bc7fefc53d3b920878c08c4cc914", "SELECT query_string, fingerprint FROM peloton.pg_catalog.pg_query_history;|01851b97a4b7d3bc7fefc53d3b920878c08c4cc914" }

…Bug in index metric catalog

…metric test.

Tianyi Chen and others added 30 commits April 9, 2018 21:01

remove dead code

5d737ff

add comment on tuple.h

d43cbe9

add in stats_aggregator

2c1984f

implement memory metric header

e348c6d

implement memory metric header 2 memory metric hook up

replace txn latency with query latency

072e953

init stats aggregator in a correct way

45b1003

implement memory chaning interface

62e7f0b

insert memory allocation interpolation in tile group header

1f17bea

hookup result to catalog

8174d2a

Save work

d57225f

Wrote code to ship catalogs over. Not tested

53d4646

Add GetName to all catalogs

1963520

fix compilation

7bcaed8

Save work

13022b6

Fix duplicate index creation.

454afb1

fix alloc decre bug

c1cc44e

add stats for tile with table id specified

815bf7e

reorder arguments (style)

754901b

begin new stats api

f68eafd

Merge branch '721-Proj3' of https://github.com/ChTimTsubasa/peloton i…

412ebb9

…nto 721-Proj3

begin stats_collector skeleton

de6bf06

Revert "reorder arguments (style)"

912120f

This reverts commit 754901b.

Make collector skeleton consistent with new point/interval metric API

8c94a22

Merge branch '721-Proj3' of https://github.com/ChTimTsubasa/peloton i…

912e383

…nto 721-Proj3 Conflicts: src/include/statistics/point_metric.h

differentiate tuple/index RUID

783d5aa

define collection point type

6135ca2

implement point_metric atomic collect

3cc0df7

modify interface

c1ad72c

Tianyi Chen added 3 commits May 12, 2018 00:57

internal type for test stats mode

4a03388

test metric done

ae71879

format

56d0fdf

swimj and others added 14 commits May 12, 2018 01:47

write update table metric catalog api

43748b9

implement working table metric catalog update

1f835d1

Merge branch '721-Proj3' of https://github.com/ChTimTsubasa/peloton i…

8a87b19

…nto 721-Proj3

address request, address validation and change header

db95e98

implement database metric write to catalog

a9e8b65

Merge branch '721-Proj3' of https://github.com/ChTimTsubasa/peloton i…

617851a

…nto 721-Proj3

Save work

819af2d

Merge branch '721-Proj3' of https://github.com/ChTimTsubasa/peloton i…

3fafea2

…nto 721-Proj3

implement index metric write to catalog

53d6e95

Add TupleAccess metric

46ac7cb

fix documentation for FetchData()

cb3d75d

Merge branch '721-Proj3' of https://github.com/ChTimTsubasa/peloton i…

4562be6

…nto 721-Proj3 # Conflicts: # src/catalog/index_metrics_catalog.cpp # src/include/catalog/index_metrics_catalog.h # src/statistics/index_metric.cpp

Merge branch '721-Proj3' of https://github.com/ChTimTsubasa/peloton i…

f61a7fc

…nto 721-Proj3

combine FetchData with WriteToCatalog“

f63adc4

sivaprasadsudhir suggested changes May 13, 2018

View reviewed changes

Tianyi Chen and others added 10 commits May 12, 2018 21:30

seperate varlen & inline memory stats

2070d93

Hook up TupleAccessMetric

908ce19

Hack job to make collection only work for external transactions

8044049

Try siva's suggestion on fix for query log test

569d947

Instantiate TupleAccessMetricCatalog

9feaf0a

Add comments to abstract metrics

06b093d

Change catalog data counter type to BIGINT. Fix IndexMetricSearching …

e55f73a

…Bug in index metric catalog

Commit txn that previously not being committed

86f23d6

Implement some util for concrete stats metric tests. Implement table …

08e606f

…metric test.

fix table metric, add table and index metric test

e12d0a2

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[15721] Peloton Self-Driving Infrastructure #1346

[15721] Peloton Self-Driving Infrastructure #1346

ChTimTsubasa commented May 5, 2018 •

edited

Loading

ChTimTsubasa commented May 12, 2018

ChTimTsubasa commented May 12, 2018

sivaprasadsudhir May 13, 2018

ChTimTsubasa May 13, 2018

[15721] Peloton Self-Driving Infrastructure #1346

Are you sure you want to change the base?

[15721] Peloton Self-Driving Infrastructure #1346

Conversation

ChTimTsubasa commented May 5, 2018 • edited Loading

ChTimTsubasa commented May 12, 2018

ChTimTsubasa commented May 12, 2018

sivaprasadsudhir May 13, 2018

Choose a reason for hiding this comment

ChTimTsubasa May 13, 2018

Choose a reason for hiding this comment

ChTimTsubasa commented May 5, 2018 •

edited

Loading