Skip to content
This repository has been archived by the owner on Sep 27, 2019. It is now read-only.

[15721] Schema Change Final PR #1366

Open
wants to merge 61 commits into
base: master
Choose a base branch
from
Open

[15721] Schema Change Final PR #1366

wants to merge 61 commits into from

Conversation

DeanChensj
Copy link
Contributor

Overview:

  • Blocking schema changes implementation for Add/Drop column, Rename column, and Alter column type.
  • Junit test for ALTER TABLE / Rename operations.
  • Benchmark to compare ALTER TABLE performance against Postgress & MySQL.
  • Bugs fix and addressed previous comments.

Eg queries:

  • ALTER TABLE table_name ADD COLUMN column_name column_type, DROP column_name, ALTER column_name column_type;
  • ALTER TABLE table_name RENAME column_name TO column_name;

Known issues:

  • In wait-based txn management, per-table lock is need within alter_executor
  • Mulit-txn bugs as mentioned in issues @1356, can be fixed by merging pr @1327.
  • Dropping the last column in the table will crash the pelton.
  • Foreign Key constraints need to be addressed in the future work.

DeanChensj and others added 30 commits May 14, 2018 15:09
@DeanChensj
add alter table catalog
238f5f3
@DeanChensj
add change column catalog
0f883a3
@DeanChensj
Revert "Merge pull request #1 from DeanChensj/catlog"
2a7421b 
This reverts commit 6704d0e, reversing
changes made to 39fa518.
@Dingshilun @DeanChensj
This commit added parser support of alter table
9478c11 
    - added alter and rename plan and statements
    - modified optimizor to bind db name and make plans
    - modified parsenodes
    - added node to string support and vice versa
    - added nodetransform of alter table
@sxzh93 @DeanChensj
add rename column executor
45793c9
@DeanChensj
Catalog for change column name
c0bf622
@sxzh93 @DeanChensj
resolve comments, add header, TODO, remove context in subclass
dc8fdef
@sxzh93 @DeanChensj
fix
f99d74a
@DeanChensj
add alter table catalog
93b4883
@DeanChensj
add change column catalog
6d52944
@DeanChensj
Revert "Merge pull request #1 from DeanChensj/catlog"
ec89247 
This reverts commit 6704d0e, reversing
changes made to 39fa518.
@Dingshilun @DeanChensj
This commit added parser support of alter table
a9f476d 
    - added alter and rename plan and statements
    - modified optimizor to bind db name and make plans
    - modified parsenodes
    - added node to string support and vice versa
    - added nodetransform of alter table
@sxzh93 @DeanChensj
add rename column executor
5c05dfc
@DeanChensj
Catalog for change column name
d21d3ec
@sxzh93 @DeanChensj
resolve comments, add header, TODO, remove context in subclass
7af2df1
@sxzh93 @DeanChensj
fix
ed0f25f
@DeanChensj
AlterTable init test
9a1f61f
@Dingshilun @DeanChensj
added headers, comments and TODO
35168ee
@DeanChensj
remove comments
f098817
@DeanChensj
add alter table catalog
636abfd
@DeanChensj
add change column catalog
694582c
@DeanChensj
Revert "Merge pull request #1 from DeanChensj/catlog"
1ec004e 
This reverts commit 6704d0e, reversing
changes made to 39fa518.
@sxzh93 @DeanChensj
add rename column executor
c339c95
@DeanChensj
Catalog for change column name
e234829
@sxzh93 @DeanChensj
fix
29d35a9
@DeanChensj
add alter table catalog
d81697c
@DeanChensj
add change column catalog
d122913
@DeanChensj
Revert "Merge pull request #1 from DeanChensj/catlog"
34f3c05 
This reverts commit 6704d0e, reversing
changes made to 39fa518.
@sxzh93 @DeanChensj
add rename column executor
17f7b80
@DeanChensj
Catalog for change column name
a495aa7
sxzh93 and others added 24 commits May 14, 2018 15:29
@sxzh93 @DeanChensj
fix
a50f7b2
@Dingshilun @DeanChensj
This commit added parser support of alter table
fd7531d 
    - added alter and rename plan and statements
    - modified optimizor to bind db name and make plans
    - modified parsenodes
    - added node to string support and vice versa
    - added nodetransform of alter table
@Dingshilun @DeanChensj
added alter table drop column parser, planner, and catalog support, w…
76ea89e 
…aiting for executor
@sxzh93 @DeanChensj
add drop column executor
7d6fa8a
@Dingshilun @DeanChensj
refacted the rename into alter (parser, planner)
2462059
@Dingshilun @DeanChensj
added parser support for change column type and add column
27483c1 
small modification
@DeanChensj
new implement of rename
6584cdb
@DeanChensj
alter table in catalog
1f2c1c0
@Dingshilun @DeanChensj
added change type into alter tabe
900502d
@sxzh93 @DeanChensj
add alter executor
c327fb6
@sxzh93 @DeanChensj
resolve pr comments
2ea140e
@Dingshilun @DeanChensj
modified alter plan, fixed bugs
56a2e44
@Dingshilun @DeanChensj
added change type, changed logic in alter_executor, varchar still not…
6d1961c 
… suppport
@DeanChensj
addressed comments and fix varchar
764fcfb
@DeanChensj
basic test for alterTable
4924383
@sxzh93 @DeanChensj
add alter table tests, change unsupported type, multiple operation in…
02b0fdc 
… a statement
@Dingshilun @DeanChensj
added alter varchar length support, changed the plan to use schema
a08410d 
addressed bug
@Dingshilun @DeanChensj
addressed the modification from cmu-db master
d20a924
@DeanChensj
change type quick fix
f8b10a5
@DeanChensj
add gc logic
8a51c36
@Dingshilun @DeanChensj
added alter benchmark, leave all workload of benchmark to be empty
470323a
@DeanChensj
Fix auto-merge conflict
6c986fd
@DeanChensj
Addressed commments from index team
9001841
@Dingshilun
modified AlterBenchmarkTest to support multiple SQL
3953b2f
@coveralls
Copy link

coveralls commented May 15, 2018 •
edited
Loading

Coverage Status

Coverage decreased (-0.9%) to 76.666% when pulling 19eac34 on sxzh93:final into 5686479 on cmu-db:master.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
class-project do not merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@DeanChensj @coveralls @saatviks @Dingshilun @sxzh93