This repository has been archived by the owner on Sep 27, 2019. It is now read-only.
Sequences #1407
Open
Sequences #1407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cmu-db#1345 Checking in the testing files from cmu-db#1345 These should be the last files that we need from from cmu-db#1345 This compiles and passes all the tests except for the sequence test (obviously)
This was referenced Jun 21, 2018
…or you: + Starting to clean up CatalogCache API + Added the ability to get SchemaCatalog objects from DatabaseCatalog I still need to think through the proper API for retrieving a Sequence from the catalog. I will format the new files next
… know if we need to always pass around the namespace oid...
… yet here we are! Removing the microbenchmarks! No longer will we get TPC-C numbers by running embedded logic. We will keep everything real over JDBC. I would like to give a shout out to KB for sticking with me all this time. I am sitting in a German hotel waiting for her to fly in from Pittsburgh tomorrow.
|
@lmwnshn There seems to be a lot of refactors in this PR not necessarily related to sequences. We can probably get those into a separate PR and merge those immediately. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a cleaned up version of #1345. I removed the need for temp tables since @poojanilangekar doesn't need that. This PR is still broken. I still need to fix the basic functionality. I also debating whether to bring in the new
SessionContextcode from #1397.https://www.youtube.com/watch?v=3mmdD0pBBck