This repository has been archived by the owner on Sep 27, 2019. It is now read-only.
Protocol Layer Refactor #1445
Open
Protocol Layer Refactor #1445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o tianyu-refactor
…u-refactor-debug # Conflicts: # src/include/network/service/connection_manager.h # src/include/network/service/message_queue.h # src/include/network/service/peloton_client.h # src/include/network/service/peloton_endpoint.h # src/include/network/service/peloton_service.h # src/include/network/service/rpc_channel.h # src/include/network/service/rpc_client.h # src/include/network/service/rpc_method.h # src/include/network/service/rpc_server.h # src/include/network/service/rpc_type.h # src/include/network/service/rpc_utils.h # src/include/network/service/tcp_connection.h # src/include/network/service/tcp_listener.h # src/network/service/connection_manager.cpp # src/network/service/peloton_service.cpp # src/network/service/rpc_channel.cpp # src/network/service/rpc_client.cpp # src/network/service/rpc_server.cpp # src/network/service/rpc_utils.cpp # src/network/service/tcp_connection.cpp # src/network/service/tcp_listener.cpp # test/codegen/csv_scan_translator_test.cpp
… code over to the new structure.
…u-protocol-refactor # Conflicts: # src/include/common/notifiable_task.h # src/include/network/connection_dispatcher_task.h # src/include/network/connection_handle.h # src/include/network/marshal.h # src/include/network/network_io_wrapper_factory.h # src/include/network/network_io_wrappers.h # src/include/network/peloton_server.h # src/network/connection_handle.cpp # src/network/network_io_wrapper_factory.cpp # src/network/network_io_wrappers.cpp # src/network/postgres_protocol_handler.cpp
…loton into tianyu-protocol-refactor
… of endian conversion.
…e of txn_state_ to IDLE.
…om/tli2/peloton into tianyu-protocol-refactor-structure
ChTimTsubasa
previously approved these changes
Jul 4, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Protocol handler and traffic cop, as it stands currently, are completely intertwined, and rank very high on my "worst code ever seen" list. There is so much duct tape and coat hangers here, it pretty wrecks testability and extensibility of the code. We will have to refactor this in phases.
This PR will separate out all the components like they should be. @ChTimTsubasa is working on another PR based on this to fix the broken transaction handling logic.