7dav new geo ids #1416
Merged
7dav new geo ids #1416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved check_val_missing to dynamic checks. Increased granularity, now informs for each geo_id+date combination for missing values Ignores first 6 days of the checking period since 7dav signals return NAs as part of smoothing
Move check_na_values to test_dynamic, changed test assertions to fit
qx-teo
commented
Dec 10, 2021
Keeping error_name as check_val_missing for easier processing, shifted relavant info to message
Added na value outside of checking range to test for filtering
Apply filter to df to only consider dates within the checking window
|
@nmdefries this should be fixed now, failing test as a result of #1477 |
nmdefries
approved these changes
Jan 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
7dav signals give NA values for the first 6 days a new geo_id is introduced, as there is not enough data for the smoother. We fix this by shifting the check to dynamic checks, and checking row by row (ignoring the first 6 rows of each geo_id in the checking window)
Changelog
Itemize code/test/documentation changes and files added/removed.