Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nssp patching code #2000
base: main
Are you sure you want to change the base?
nssp patching code #2000
Changes from 5 commits
c78ae21
7694c0a
a3ed4c2
1628d34
2536b94
e4d45e5
db906fc
8f0bb32
7f151f5
c093349
a967416
c020da6
9a6130b
b8a2177
a7d9443
e29e07e
0a4bfb6
6c0abad
7078dd0
d435bf0
8734daa
5a6f8b6
4356494
ca427a4
f58b068
5e93175
2d8670d
f0335f6
7e06f94
e678ce6
bc1d7a7
84cba84
742737b
e13d3db
9cec6ff
5450d8b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: why do we need to make a backup? Also suggest putting this in a indicator-specific dir inside of the testing-utils dir.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: what is the
source_dir
used for? Isn't NSSP data fetched from an API?Ideally, I'd like the patch params to be the same between indicators. Is
source_dir
info that we already have somewhere else (e.g. if it's required for a patch, maybe it's also required for a normal run, in which case it would be stored in theindicator
section?)?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nssp data is fetched from an API when it is run normally. The API does not have versioning (the numbers do gets updated), so we keep a daily stash of what the api returns every day on a separate server, which is used here as source data for issue dates in patching.