Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more logging and cleaned logic #2076

Merged
merged 6 commits into from
Nov 13, 2024
Merged

Conversation

aysim319
Copy link
Contributor

@aysim319 aysim319 commented Nov 7, 2024

Description

added logic to check to see if result from bigquery is none and continue if empty, also added new more logging

Associated Issue(s)

@aysim319 aysim319 marked this pull request as ready for review November 7, 2024 19:10
Copy link
Contributor

@nolangormley nolangormley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just want that one comment verified and I will approve.

Copy link
Contributor

@nolangormley nolangormley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aysim319 aysim319 merged commit e7eccaa into main Nov 13, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants