Make sure GitHub date-request errors are raised #658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dshemetov
reviewed
Aug 24, 2023
| }, | ||
| error = function(e) cat(sprintf("%i. %s\n", i, e$message)) | ||
| ) | ||
| forecaster_dates[[i]] <- lubridate::as_date(get_covidhub_forecast_dates(forecasters[i])) |
There was a problem hiding this comment.
mostly out of scope, but if you know off the top of your head, im curious: why are we using lubridate here instead of just as_date?
There was a problem hiding this comment.
I'm not sure. (All the other as_dates should really be loading directly from lubridate since we're not importing the function.)
dshemetov
approved these changes
Aug 25, 2023
|
Thoughts on adding a retry to get_forecast_dates in case it fails due to some HTTP hiccup? |
|
@dshemetov I added a retry step. This should be ready so please re-review/merge when you have a chance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
httr::stop_for_statusto error on any non-successful, non-403 (for which we have special handling) status. Remove thetryCatchwrapper so that the errors actually cause the call to exit.I'm not sure what errors the
tryCatchwas originally intended to catch, but there are a couple reasons to remove it. First, without valid dates, downstream calls won't get valid forecast data. And fetching forecast dates is relatively fast. It isn't a big problem to rerun. It also tests GitHub API authentication, which is necessary for time-consuming forecast downloads later.