Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(acquisition): remove and deactivate norostat #1207

Merged
merged 3 commits into from
Jun 23, 2023
Merged

feat(acquisition): remove and deactivate norostat #1207

merged 3 commits into from
Jun 23, 2023

Conversation

dshemetov
Copy link
Contributor

closes #1205

Summary:

  1. Deletes the Norostat acquisition pipeline code
  2. Removes it from delpoy.json
  3. Updates Norostat documentation to say that the signal stopped updating in November 2020

Prerequisites:

  • Unless it is a documentation hotfix it should be merged against the dev branch
  • Branch is up-to-date with the branch to be merged with, i.e. dev
  • Build is successful
  • Code is cleaned up and formatted

@sonarcloud
Copy link

sonarcloud bot commented Jun 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dshemetov dshemetov requested a review from krivard June 23, 2023 18:48
melange396
melange396 approved these changes Jun 23, 2023
View reviewed changes
Copy link
Collaborator

@melange396 melange396 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RIP

@dshemetov dshemetov mentioned this pull request Jun 23, 2023
Closed
4 tasks
@dshemetov dshemetov merged commit 13fcfe3 into dev Jun 23, 2023
5 checks passed
@dshemetov dshemetov deleted the ds/del-norostat-acquisition branch June 23, 2023 19:51
@nolangormley nolangormley mentioned this pull request Jun 27, 2023
Merged
This was referenced Aug 18, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melange396 melange396 melange396 approved these changes

@krivard krivard Awaiting requested review from krivard

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deactivate & mothball norostat
2 participants
@dshemetov @melange396