-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added host to database connection strings #1212
base: dev
Are you sure you want to change the base?
Added host to database connection strings #1212
Conversation
9e5ab98
to
cc5e1c6
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good... but before merging (as in #1211), we need to figure out if there are data migrations that need to happen and plan/schedule those. its also possible that many of these jobs may not even be on the run queue right now, but we will need someone with knowledge of and credentials for cronicle to help us determine that.
# connect | ||
u, p = secrets.db.auto | ||
cnx = mysql.connector.connect(user=u, password=p, database="automation") | ||
cnx = mysql.connector.connect(user=u, password=p, database="automation", host=secrets.db.host) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this uses a different database than the others (they use "epidata"), and on prod, the "automation" database has no tables in it. im guessing this job isnt being run in cronicle currently, but its worth checking up on it.
Co-authored-by: melange396 <[email protected]>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
…-that-might-still-be-running-without-a-db-host-specified
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
…-that-might-still-be-running-without-a-db-host-specified
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
Summary:
Added missing host to database connection strings to avoid wrong database connection
Prerequisites:
dev
branchdev