Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sorting in compute_covidcast_meta #1243

Merged
merged 1 commit into from
Aug 1, 2023
Merged

Fix sorting in compute_covidcast_meta #1243

merged 1 commit into from
Aug 1, 2023

Conversation

dmytrotsko
Copy link
Contributor

Summary:

Fixex sorting in compute_covidcast_meta
Added missing api_user creation in integrations/acquisition/covidcast/

Prerequisites:

  • Branch is up-to-date with the branch to be merged with, i.e. dev
  • Build is successful
  • Code is cleaned up and formatted

@dmytrotsko dmytrotsko linked an issue Jul 24, 2023 that may be closed by this pull request
consider using sort(key=...) function #573
Closed
@dmytrotsko dmytrotsko force-pushed the 573-consider-using-sortkey=-function branch from e41c0f5 to eebfdbe Compare July 26, 2023 15:15
@sonarcloud
Copy link

sonarcloud bot commented Jul 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

melange396
melange396 approved these changes Aug 1, 2023
View reviewed changes
Copy link
Collaborator

@melange396 melange396 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@melange396 melange396 merged commit eb46bf2 into dev Aug 1, 2023
6 checks passed
@melange396 melange396 deleted the 573-consider-using-sortkey=-function branch August 1, 2023 18:43
@dmytrotsko dmytrotsko mentioned this pull request Aug 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melange396 melange396 melange396 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

consider using sort(key=...) function
2 participants
@dmytrotsko @melange396