Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ISO range parsing #1284

Merged
merged 3 commits into from
Sep 21, 2023
Merged

Fix ISO range parsing #1284

merged 3 commits into from
Sep 21, 2023

Conversation

dmytrotsko
Copy link
Contributor

Summary:

Fixed ISO range parsing for /covidcast endpoint

Prerequisites:

  • Branch is up-to-date with the branch to be merged with, i.e. dev
  • Build is successful
  • Code is cleaned up and formatted

@dmytrotsko dmytrotsko linked an issue Aug 30, 2023 that may be closed by this pull request
covidcast endpoint - inconsistent handling of ISO format dates #1153
Closed
@dmytrotsko dmytrotsko mentioned this pull request Sep 15, 2023
Closed
@dshemetov
Copy link
Contributor

Could you add some tests for this case here?

melange396
melange396 reviewed Sep 18, 2023
View reviewed changes
src/server/_params.py Outdated Show resolved Hide resolved
melange396
melange396 reviewed Sep 18, 2023
View reviewed changes
src/server/_params.py Outdated Show resolved Hide resolved
melange396
melange396 reviewed Sep 18, 2023
View reviewed changes
src/server/_params.py Outdated Show resolved Hide resolved
melange396
melange396 requested changes Sep 18, 2023
View reviewed changes
Copy link
Collaborator

@melange396 melange396 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just a few small things. Dmitry's suggestion is worth doing too.

@sonarcloud
Copy link

sonarcloud bot commented Sep 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

melange396
melange396 approved these changes Sep 18, 2023
View reviewed changes
Copy link
Collaborator

@melange396 melange396 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dmytrotsko dmytrotsko merged commit 63243a8 into dev Sep 21, 2023
6 checks passed
@dmytrotsko dmytrotsko deleted the 1153-covidcast-endpoint-inconsistent-handling-of-iso-format-dates branch September 21, 2023 19:35
@dmytrotsko dmytrotsko mentioned this pull request Sep 28, 2023
Merged
@melange396 melange396 mentioned this pull request Oct 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melange396 melange396 melange396 approved these changes

@rzats rzats Awaiting requested review from rzats

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

covidcast endpoint - inconsistent handling of ISO format dates
3 participants
@dmytrotsko @dshemetov @melange396