revert and deprecate async_epidata (+ Remove usage of PHP alias in the Python client) #1295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rzats can you make this failing test work? I think it might be pretty easily fixable if you use |
dshemetov
approved these changes
Oct 4, 2023
melange396
commented
Oct 4, 2023
| responses = [i[0]["epidata"] for i in test_output] | ||
| # check response is same as standard covidcast call (minus fields omitted by the api.php endpoint), | ||
| # using 24 calls to test batch sizing | ||
| ignore_fields = ["source", "time_type", "geo_type"] |
There was a problem hiding this comment.
instead of re-defining, use existing list:
Suggested change
| ignore_fields = ["source", "time_type", "geo_type"] | |
| ignore_fields = CovidcastTestRow._api_row_compatibility_ignore_fields |
Comment on lines
349
to
350
| [{k: v for k, v in row.items() if k not in ignore_fields} for row in Epidata.covidcast(**self.params_from_row(rows[0]))["epidata"]], | ||
| [{k: v for k, v in row.items() if k not in ignore_fields} for row in Epidata.covidcast(**self.params_from_row(rows[1]))["epidata"]], |
There was a problem hiding this comment.
this is slightly more concise...
Suggested change
| [{k: v for k, v in row.items() if k not in ignore_fields} for row in Epidata.covidcast(**self.params_from_row(rows[0]))["epidata"]], | |
| [{k: v for k, v in row.items() if k not in ignore_fields} for row in Epidata.covidcast(**self.params_from_row(rows[1]))["epidata"]], | |
| [{k: row[k] for k in row.keys() - ignore_fields} for row in Epidata.covidcast(**self.params_from_row(rows[0]))["epidata"]], | |
| [{k: row[k] for k in row.keys() - ignore_fields} for row in Epidata.covidcast(**self.params_from_row(rows[1]))["epidata"]], |
rzats
approved these changes
Oct 4, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
awesome!!! thank you @dshemetov ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
whoops, i wasnt paying attention on the command line and my commit message got slightly mangled, it should read:
"revert
async_epidata()to previous behavior, and mark deprecated (filterwarnings()not fully tested)"to be added to #1288
i did not do much testing around the
warnings.filterwarnings()call, but it is intended to print the deprecation warning for the method only once (on its first use), no matter howasync_epidata()is called.